From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUkhT-0007C9-Mn for qemu-devel@nongnu.org; Wed, 16 May 2012 16:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUkhR-0002mP-Us for qemu-devel@nongnu.org; Wed, 16 May 2012 16:19:59 -0400 Received: from mx.meyering.net ([88.168.87.75]:38905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUkhR-0002lp-Kb for qemu-devel@nongnu.org; Wed, 16 May 2012 16:19:57 -0400 From: Jim Meyering In-Reply-To: <1337173681-25891-3-git-send-email-jim@meyering.net> (Jim Meyering's message of "Wed, 16 May 2012 15:07:57 +0200") References: <1337173681-25891-1-git-send-email-jim@meyering.net> <1337173681-25891-3-git-send-email-jim@meyering.net> Date: Wed, 16 May 2012 22:19:55 +0200 Message-ID: <87wr4bubdg.fsf_-_@rho.meyering.net> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCHv2 2/6] qemu-ga: don't leak a file descriptor upon failed lockf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil , Anthony Liguori , Michael Roth , Stefan Hajnoczi , Luiz Capitulino Signed-off-by: Jim Meyering --- qemu-ga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-ga.c b/qemu-ga.c index 680997e..24b236a 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -246,6 +246,9 @@ static bool ga_open_pidfile(const char *pidfile) pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR); if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) { g_critical("Cannot lock pid file, %s", strerror(errno)); + if (pidfd != -1) { + close(pidfd); + } return false; } -- 1.7.10.2.520.g6a4a482