From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v8 0/8] Consolidate cpuidle functionality Date: Tue, 20 Mar 2012 17:10:52 -0700 Message-ID: <87wr6evmnn.fsf@ti.com> References: <1332274969-15782-1-git-send-email-rob.lee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1332274969-15782-1-git-send-email-rob.lee@linaro.org> (Robert Lee's message of "Tue, 20 Mar 2012 15:22:41 -0500") Sender: linux-kernel-owner@vger.kernel.org To: Robert Lee Cc: len.brown@intel.com, akpm@linux-foundation.org, rjw@sisk.pl, robherring2@gmail.com, Baohua.Song@csr.com, amit.kucheria@linaro.org, nicolas.ferre@atmel.com, linux@maxim.org.za, kgene.kim@samsung.com, amit.kachhap@linaro.org, magnus.damm@gmail.com, nsekhar@ti.com, daniel.lezcano@linaro.org, mturquette@linaro.org, vincent.guittot@linaro.org, arnd.bergmann@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-dev@lists.linaro.org, patches@linaro.org, deepthi@linux.vnet.ibm.com, broonie@opensource.wolfsonmicro.com, nicolas.pitre@linaro.org, linux@arm.linux.org.uk, jean.pihet@newoldbits.com, venki@google.com, ccross@google.com, g.trinabh@gmail.com, kernel@wantstofly.org, lethal@linux-sh.org, jon-hunter@ti.com, tony@atomide.com, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org List-Id: linux-omap@vger.kernel.org Hi Rob, Robert Lee writes: > This patch series moves various functionality duplicated in platform > cpuidle drivers to the core cpuidle driver. Also, the platform irq > disabling was removed as it appears that all calls into > cpuidle_call_idle will have already called local_irq_disable(). > > These changes have been pulled into linux-next. > > Len, Andrew, can a request be made for Linus to pull these changes? > > Acked-by: Jean Pihet (v6) > Tested-by: Jean Pihet (v6, omap3) > Tested-by: Amit Daniel (v6, Exynos4) > Tested-by: Robert Lee (imx51, imx6q) Note that there's a space missing between the name and email in these tags (and for Deepthi's below also.) That seems to exist in all the patches. > Reviewed-by: Kevin Hilman For my Reviewed-by, it only applies to the core code and the OMAP changes. I haven't reviewed the other platform-specific drivers. I believe the same applies to Jean Pihet who works with me on OMAP. > Reviewed-by: Daniel Lezcano > Reviewed-by: Deepthi Dharwar (core cpuidle only) Looks like you never heard from anyone actively working on at91, shmobile, kirwood or davinci. I'm not sure we should merge those platform-specific changes without an ack from those platform maintainers. For 3.4, maybe we should just merge the core code and the platforms that have been reviewed/ack'd, and for 3.5, spent some time nagging the other platform maintainers to review and test. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Date: Wed, 21 Mar 2012 00:10:52 +0000 Subject: Re: [PATCH v8 0/8] Consolidate cpuidle functionality Message-Id: <87wr6evmnn.fsf@ti.com> List-Id: References: <1332274969-15782-1-git-send-email-rob.lee@linaro.org> In-Reply-To: <1332274969-15782-1-git-send-email-rob.lee@linaro.org> (Robert Lee's message of "Tue, 20 Mar 2012 15:22:41 -0500") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Rob, Robert Lee writes: > This patch series moves various functionality duplicated in platform > cpuidle drivers to the core cpuidle driver. Also, the platform irq > disabling was removed as it appears that all calls into > cpuidle_call_idle will have already called local_irq_disable(). > > These changes have been pulled into linux-next. > > Len, Andrew, can a request be made for Linus to pull these changes? > > Acked-by: Jean Pihet (v6) > Tested-by: Jean Pihet (v6, omap3) > Tested-by: Amit Daniel (v6, Exynos4) > Tested-by: Robert Lee (imx51, imx6q) Note that there's a space missing between the name and email in these tags (and for Deepthi's below also.) That seems to exist in all the patches. > Reviewed-by: Kevin Hilman For my Reviewed-by, it only applies to the core code and the OMAP changes. I haven't reviewed the other platform-specific drivers. I believe the same applies to Jean Pihet who works with me on OMAP. > Reviewed-by: Daniel Lezcano > Reviewed-by: Deepthi Dharwar (core cpuidle only) Looks like you never heard from anyone actively working on at91, shmobile, kirwood or davinci. I'm not sure we should merge those platform-specific changes without an ack from those platform maintainers. For 3.4, maybe we should just merge the core code and the platforms that have been reviewed/ack'd, and for 3.5, spent some time nagging the other platform maintainers to review and test. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Tue, 20 Mar 2012 17:10:52 -0700 Subject: [PATCH v8 0/8] Consolidate cpuidle functionality In-Reply-To: <1332274969-15782-1-git-send-email-rob.lee@linaro.org> (Robert Lee's message of "Tue, 20 Mar 2012 15:22:41 -0500") References: <1332274969-15782-1-git-send-email-rob.lee@linaro.org> Message-ID: <87wr6evmnn.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, Robert Lee writes: > This patch series moves various functionality duplicated in platform > cpuidle drivers to the core cpuidle driver. Also, the platform irq > disabling was removed as it appears that all calls into > cpuidle_call_idle will have already called local_irq_disable(). > > These changes have been pulled into linux-next. > > Len, Andrew, can a request be made for Linus to pull these changes? > > Acked-by: Jean Pihet (v6) > Tested-by: Jean Pihet (v6, omap3) > Tested-by: Amit Daniel (v6, Exynos4) > Tested-by: Robert Lee (imx51, imx6q) Note that there's a space missing between the name and email in these tags (and for Deepthi's below also.) That seems to exist in all the patches. > Reviewed-by: Kevin Hilman For my Reviewed-by, it only applies to the core code and the OMAP changes. I haven't reviewed the other platform-specific drivers. I believe the same applies to Jean Pihet who works with me on OMAP. > Reviewed-by: Daniel Lezcano > Reviewed-by: Deepthi Dharwar (core cpuidle only) Looks like you never heard from anyone actively working on at91, shmobile, kirwood or davinci. I'm not sure we should merge those platform-specific changes without an ack from those platform maintainers. For 3.4, maybe we should just merge the core code and the platforms that have been reviewed/ack'd, and for 3.5, spent some time nagging the other platform maintainers to review and test. Kevin