All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] add option to enable AI_ADDRCONFIG support
Date: Sun, 11 Mar 2012 21:56:22 +0100	[thread overview]
Message-ID: <87wr6q26x5.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20120308091714.5d60b715@skate> (Thomas Petazzoni's message of "Thu, 8 Mar 2012 09:17:14 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas> I don't know if this question has been asked in the past, but do you
 Thomas> know what is the binary size impact of enabling AI_ADDRCONFIG in
 Thomas> uClibc? If the impact is rather minimal, then I'd rather have it
 Thomas> enabled in our default configuration instead of adding yet another
 Thomas> toolchain config knob.

I believe it's a fairly small impact, but the problem is external uClibc
toolchains (made by BR, ct-NG or elsewhere) which most likely won't have
AI_ADDRCONFIG enabled, so mrouted (and gupnp) will fail at build time.


 Thomas> Anyway some comments about your patches (but don't work on updating
 Thomas> them before we decide if a new option is really needed) :

 Thomas>  * Your PATCH 1/2 also needs to address the cases of external
 Thomas>    toolchains and crosstool-ng toolchains ;

 Thomas>  * Your PATCH 2/2 should use a depends on rather than a select. We use
 Thomas>    depends on for all the dependencies of packages on toolchain
 Thomas>    options, together with a comment displayed when the toolchain
 Thomas>    options isn't present, so that the user is aware that mrouted is
 Thomas>    available, but only if AI_ADDRCONFIG is enabled as a toolchain
 Thomas>    option.

I agree.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-03-11 20:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 22:38 [Buildroot] add option to enable AI_ADDRCONFIG support Sven Neumann
2012-03-07 22:38 ` [Buildroot] [PATCH 1/2] toolchain: add option to enable AI_ADDRCONFIG support in uclibc Sven Neumann
2012-03-11 20:53   ` Peter Korsgaard
2012-03-07 22:38 ` [Buildroot] [PATCH 2/2] mrouted: select BR2_TOOLCHAIN_BUILDROOT_INET_ADDRCONFIG Sven Neumann
2012-03-08  8:17 ` [Buildroot] add option to enable AI_ADDRCONFIG support Thomas Petazzoni
2012-03-11 20:56   ` Peter Korsgaard [this message]
2012-03-15 20:33     ` Thomas Petazzoni
2012-03-15 20:56       ` Peter Korsgaard
2012-05-02 13:33         ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wr6q26x5.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.