From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37500)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RukKh-0000PX-MW
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:39:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RukKY-0003A9-AR
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:39:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28095)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RukKY-00039w-1X
	for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:39:30 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q17CdSAt013277
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 7 Feb 2012 07:39:28 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1328342612-25826-4-git-send-email-pbonzini@redhat.com> (Paolo
	Bonzini's message of "Sat, 4 Feb 2012 09:03:32 +0100")
References: <1328342612-25826-1-git-send-email-pbonzini@redhat.com>
	<1328342612-25826-4-git-send-email-pbonzini@redhat.com>
Date: Tue, 07 Feb 2012 13:39:26 +0100
Message-ID: <87wr7yom0x.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property
	with gpio pin to i8042
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/pc.c      |    7 +++----
>  hw/pc.h      |    1 -
>  hw/pckbd.c   |    7 +++++--
>  hw/vmmouse.c |   11 +++--------
>  4 files changed, 11 insertions(+), 15 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 7f3aa65..76787c7 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1181,13 +1181,12 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
>      if (!no_vmport) {
>          vmport_init(isa_bus);
>          vmmouse = isa_try_create(isa_bus, "vmmouse");
> +        qdev_init_nofail(&vmmouse->qdev);
> +        qdev_connect_gpio_out(DEVICE(vmmouse), 0,
> +                              qdev_get_gpio_in(DEVICE(i8042), 0));

Are you sue that vmmouse is always non-NULL?  My understanding is that
all callers check if is_try_create() return NULL.

Could you clarify?

Thanks, Juan.