From: Juan Quintela <quintela@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/6] memory: change dirty setting APIs to take a size
Date: Mon, 12 Dec 2011 11:45:57 +0100 [thread overview]
Message-ID: <87wra26pay.fsf@trasno.mitica> (raw)
In-Reply-To: <CAAu8pHsYtFV3RhRFhPNs8Xrj3W+R6uBYEy7sNnTt3-7RhTcOPA@mail.gmail.com> (Blue Swirl's message of "Sat, 10 Dec 2011 16:44:37 +0000")
Blue Swirl <blauwirbel@gmail.com> wrote:
> Instead of each target knowing or guessing the guest page size,
> just pass the desired size of dirtied memory area. This should also
> improve performance due to memset() optimizations.
My understanding last time I looked at this, is that it is as easy
basically to change the interface to work on pages, not on addresses.
I looked at the interface from the point of view of migration, and I
always needed a "page". My understanding at the time was that every
caller could be change to use a page instead, but that is another set of
"unfinished" patches on my ToDo list.
Actually, what I found what I needed was that I wanted a pointer to the
ram_block on that functions. Migration and vga were simple to fix, but
TCG got me completely lost :-(, and at that point I moved to someting else.
Will try to think what were my problems later today.
Later, Juan.
prev parent reply other threads:[~2011-12-12 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 16:44 [Qemu-devel] [PATCH 2/6] memory: change dirty setting APIs to take a size Blue Swirl
2011-12-11 9:20 ` Avi Kivity
2011-12-12 10:45 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wra26pay.fsf@trasno.mitica \
--to=quintela@redhat.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.