From: Kevin Hilman <khilman@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, nm@ti.com,
Vishwanath BS <vishwanath.bs@ti.com>
Subject: Re: [PATCHv4 01/15] OMAP3+: PM: VP: use uV for max and min voltage limits
Date: Fri, 09 Dec 2011 10:07:39 -0800 [thread overview]
Message-ID: <87wra5fwk4.fsf@ti.com> (raw)
In-Reply-To: <1322236188-19456-2-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Fri, 25 Nov 2011 17:49:34 +0200")
Tero Kristo <t-kristo@ti.com> writes:
> From: Nishanth Menon <nm@ti.com>
>
> Every PMIC has it's own eccentricities, For example, one of the
> PMIC has MSB set to 1 for a specific function - voltage enable!
> using an hardcoded value specific for TWL when copied over to
> such an implementation causes the system to crash as the MSB bit
> was 0 and the voltage got disabled!.
>
> Instead we use actual values and depend on the convertion routines
> to abstract out the eccentricities of each PMIC.
>
> With this, we can now move the voltages to a common location in
> voltage.h as they are no longer dependent on PMICs and expect the
> PMIC's conversion routines to set a cap if the voltage is out of
> reach for the PMIC.
Nice.
> Reported-by: Jon Hunter <jon-hunter@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
Also needs your sign-off, since you're on the delivery path now.
Kevin
next prev parent reply other threads:[~2011-12-09 18:07 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 15:49 [PATCHv4 00/15] voltdm cleanup + auto-ret / auto-off support Tero Kristo
2011-11-25 15:49 ` [PATCHv4 01/15] OMAP3+: PM: VP: use uV for max and min voltage limits Tero Kristo
2011-12-09 18:07 ` Kevin Hilman [this message]
2011-12-12 9:39 ` Tero Kristo
2011-11-25 15:49 ` [PATCHv4 02/15] omap3+: voltage: parameter segregation Tero Kristo
2011-11-29 18:26 ` Menon, Nishanth
2011-11-30 10:07 ` Tero Kristo
2011-11-30 12:31 ` Menon, Nishanth
2011-11-30 13:04 ` Tero Kristo
2011-11-30 10:11 ` Jean Pihet
2011-11-25 15:49 ` [PATCHv4 03/15] omap: voltage: add definition for pmic startup / shutdown times Tero Kristo
2011-11-25 15:49 ` [PATCHv4 04/15] omap4: add " Tero Kristo
2011-11-29 18:30 ` Menon, Nishanth
2011-11-30 9:45 ` Tero Kristo
2011-11-30 12:20 ` Menon, Nishanth
2011-11-30 13:08 ` Tero Kristo
2011-11-25 15:49 ` [PATCHv4 05/15] omap: add support for oscillator setup Tero Kristo
2011-12-09 18:27 ` Kevin Hilman
2011-12-12 9:40 ` Tero Kristo
2011-11-25 15:49 ` [PATCHv4 06/15] omap3+: vp: use new vp_params for calculating vddmin and vddmax Tero Kristo
2011-11-29 18:34 ` Menon, Nishanth
2011-11-25 15:49 ` [PATCHv4 07/15] omap3+: voltage: use oscillator data to calculate setup times Tero Kristo
2011-11-25 15:49 ` [PATCHv4 08/15] omap4: use pmic params for calculating pmic " Tero Kristo
2011-11-25 15:49 ` [PATCHv4 09/15] TEMP: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-11-25 15:49 ` [PATCHv4 10/15] omap: beagle: set oscillator startup time to 10ms for rev c4 Tero Kristo
2011-12-09 19:11 ` Kevin Hilman
2011-12-12 9:42 ` Tero Kristo
2011-11-25 15:49 ` [PATCHv4 11/15] omap3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2011-11-30 9:52 ` Jean Pihet
2011-11-30 10:11 ` Tero Kristo
2011-12-09 19:37 ` Kevin Hilman
2011-12-12 9:45 ` Tero Kristo
2011-11-25 15:49 ` [PATCHv4 12/15] vc: omap3: auto_ret / auto_off support Tero Kristo
2011-12-09 20:13 ` Kevin Hilman
2011-12-12 9:53 ` Tero Kristo
2011-12-12 15:05 ` Kevin Hilman
2011-11-25 15:49 ` [PATCHv4 13/15] omap3: fix usecount tracking Tero Kristo
2011-11-25 15:49 ` [PATCHv4 14/15] omap3: voltage: fix channel configuration Tero Kristo
2011-11-25 15:49 ` [PATCHv4 15/15] omap: pm: wait for domain wakeup if changing state of idle domain Tero Kristo
2011-11-30 10:06 ` [PATCHv4 00/15] voltdm cleanup + auto-ret / auto-off support Jean Pihet
2011-11-30 10:19 ` Tero Kristo
2011-12-09 20:23 ` Kevin Hilman
2011-12-12 9:38 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wra5fwk4.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.