From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pA3B4NS4001014 for ; Thu, 3 Nov 2011 06:04:23 -0500 Received: from mail-bw0-f53.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id DFA1421C769 for ; Thu, 3 Nov 2011 04:04:22 -0700 (PDT) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) by cuda.sgi.com with ESMTP id LrUVFaMjdpTmTes4 for ; Thu, 03 Nov 2011 04:04:22 -0700 (PDT) Received: by bkbzs8 with SMTP id zs8so1192735bkb.26 for ; Thu, 03 Nov 2011 04:04:21 -0700 (PDT) From: Dmitry Monakhov Subject: Re: [PATCH 6/8] xfstests: add fiemap operation to fsstress In-Reply-To: References: <1319849297-3506-1-git-send-email-dmonakhov@openvz.org> <1319849297-3506-7-git-send-email-dmonakhov@openvz.org> <20111102195534.GB22500@infradead.org> Date: Thu, 03 Nov 2011 15:04:17 +0400 Message-ID: <87wrbhxya6.fsf@dmbot.sw.ru> MIME-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Theodore Tso , Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, hch@lst.de, aelder@sgi.com T24gVGh1LCAzIE5vdiAyMDExIDA2OjU0OjE2IC0wNDAwLCBUaGVvZG9yZSBUc28gPHR5dHNvQG1p dC5lZHU+IHdyb3RlOgo+IAo+IE9uIE5vdiAyLCAyMDExLCBhdCAzOjU1IFBNLCBDaHJpc3RvcGgg SGVsbHdpZyB3cm90ZToKPiAKPiA+IEFsZXgsIEVyaWMsIERhdmUgLSBzaG91bGQgd2UgYWRkIG5l dyB0ZXN0cyB3aXRoIHRoZSBuZXcgb3BlcmF0aW9ucwo+ID4gRG1pdHJ5IGFkZGVkLCBvciBpcyBh ZGRpbmcgbmV3IG9wcyB0byB0aGUgZXhpc3RpbmcgdGVzdHMgZmluZT8KPiAKPiBPbmUgYXJndW1l bnQgZm9yIGFkZGluZyBuZXcgb3BzIHRvIGV4aXN0aW5nIHRlc3RzIGlzIHRoYXQgaXQgbWFrZXMg dGhlIHJ1biB0aW1lIG9mIHRoZSBlbnRpcmUgdGVzdCBzdWl0ZSB0YWtlIGxvbmdlci4gICBBIFFB IHBhc3MgaXMgYWxyZWFkeSB0YWtpbmcgcXVpdGUgYSB3aGlsZSwgYW5kIGl0IHdvdWxkIGJlIG5p Y2UgaWYgd2UgY291bGQga2VlcCB4ZnN0ZXN0cyBhcyBlZmZpY2llbnQgYXMgcG9zc2libGUgaW4g dGVybXMgb2YgdGhlIG1heGltdW0gdGVzdGluZyBjb3ZlcmFnZSBwZXIgdGltZSBzcGVudCBydW5u aW5nIHRoZSB0ZXN0IHN1aXRl4oCmLgpZZXMsIGJ1dCByZWdyZXNzaW9uIHRlc3Qgd2l0aCBleHBs aWNpdCBzZWVkIG9wdGlvbiBzaG91bGQgYmUKcHJlc2VydmVkLiBOdW1iZXIgb2Ygc3VjaCB0ZXN0 IGlzIG5vdCB0b28gYmlnLCBzbyBpdCBpcyByZWFzb25hYmxlIHRvCmhhcmRjb2RlIHNldCBvZiBv cGVyYXRpb25zIGluIHN1Y2ggdGVzdHMgYW5kIGxldCBhbGwgb3RoZXJzIHVzZSBuZXcgZmVhdHVy ZXMuCj4gCj4gLS0gVGVkCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwp4ZnMgbWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dpLmNvbQpodHRwOi8vb3NzLnNn aS5jb20vbWFpbG1hbi9saXN0aW5mby94ZnMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 6/8] xfstests: add fiemap operation to fsstress Date: Thu, 03 Nov 2011 15:04:17 +0400 Message-ID: <87wrbhxya6.fsf@dmbot.sw.ru> References: <1319849297-3506-1-git-send-email-dmonakhov@openvz.org> <1319849297-3506-7-git-send-email-dmonakhov@openvz.org> <20111102195534.GB22500@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Theodore Tso , linux-fsdevel@vger.kernel.org, aelder@sgi.com, hch@lst.de, xfs@oss.sgi.com To: Theodore Tso , Christoph Hellwig Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:47088 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752698Ab1KCLEX convert rfc822-to-8bit (ORCPT ); Thu, 3 Nov 2011 07:04:23 -0400 Received: by bke11 with SMTP id 11so907727bke.19 for ; Thu, 03 Nov 2011 04:04:21 -0700 (PDT) In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 3 Nov 2011 06:54:16 -0400, Theodore Tso wrote: >=20 > On Nov 2, 2011, at 3:55 PM, Christoph Hellwig wrote: >=20 > > Alex, Eric, Dave - should we add new tests with the new operations > > Dmitry added, or is adding new ops to the existing tests fine? >=20 > One argument for adding new ops to existing tests is that it makes th= e run time of the entire test suite take longer. A QA pass is already= taking quite a while, and it would be nice if we could keep xfstests a= s efficient as possible in terms of the maximum testing coverage per ti= me spent running the test suite=E2=80=A6. Yes, but regression test with explicit seed option should be preserved. Number of such test is not too big, so it is reasonable to hardcode set of operations in such tests and let all others use new fea= tures. >=20 > -- Ted >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html