Re: GeForce FX5200 dual DVI & Samsung 204b

[Francisco Jerez <currojerez-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>]

[-- Attachment #1.1.1: Type: text/plain, Size: 774 bytes --]

Grzesiek Sójka <pld-t9zbU3WrWHI@public.gmane.org> writes:

> On 10/05/10 14:55, Francisco Jerez wrote:
>>> PS. I'm afraid that my system is not very stable when the AGP support
>>> is turned on both using the nouveau kernel source tree and the PLD
>>> patched 2.6.35-5 version with an extra amd-k7-agp patch. The Xserver
>>> uses the driver:
>> Unstable? How? What's the problem?
>
> Here are the logs:
> http://yen.ipipan.waw.pl/~gs159090/tmp/log.tgz
>
> BTW: Sometimes the Xserver freezes during normal work. Unfortunately I
> was not able to generate such a crush now. I send you logs if it
> happens again.
>
> Regards.
>
> [...]
> [  197.374498] kernel BUG at drivers/gpu/drm/ttm/ttm_tt.c:420!

Oops, I overlooked that, updated patch attached.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: amdk7_agp_user_memory.patch --]
[-- Type: text/x-diff, Size: 942 bytes --]

diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
index b6b1568..b1b4362 100644
--- a/drivers/char/agp/amd-k7-agp.c
+++ b/drivers/char/agp/amd-k7-agp.c
@@ -309,7 +309,8 @@ static int amd_insert_memory(struct agp_memory *mem, off_t pg_start, int type)
 
 	num_entries = A_SIZE_LVL2(agp_bridge->current_size)->num_entries;
 
-	if (type != 0 || mem->type != 0)
+	if (type != mem->type ||
+	    agp_bridge->driver->agp_type_to_mask_type(agp_bridge, type))
 		return -EINVAL;
 
 	if ((pg_start + mem->page_count) > num_entries)
@@ -348,7 +349,8 @@ static int amd_remove_memory(struct agp_memory *mem, off_t pg_start, int type)
 	unsigned long __iomem *cur_gatt;
 	unsigned long addr;
 
-	if (type != 0 || mem->type != 0)
+	if (type != mem->type ||
+	    agp_bridge->driver->agp_type_to_mask_type(agp_bridge, type))
 		return -EINVAL;
 
 	for (i = pg_start; i < (mem->page_count + pg_start); i++) {

[-- Attachment #1.2: Type: application/pgp-signature, Size: 229 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau