From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] toolchain: move makefile includes
Date: Sun, 27 Jun 2010 23:06:56 +0200 [thread overview]
Message-ID: <87wrtk2nin.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1277504132-11184-4-git-send-email-yann.morin.1998@anciens.enib.fr> (Yann E. MORIN's message of "Sat, 26 Jun 2010 00:15:30 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:
Yann> Including a bunch of Makefiles with wildcard makes it impossible
Yann> to add new toolchain backends. Avoid that by namely including
Yann> needed files.
Yann> --- /dev/null
Yann> +++ b/toolchain/toolchain-buildroot.mk
Yann> @@ -0,0 +1,14 @@
Yann> +# Include files required for the internal toolchain backend
Yann> +
Yann> +# avoid pulling in external toolchain which is broken for toplvl parallel builds
Yann> +# Explicit ordering:
Yann> +include toolchain/dependencies/dependencies.mk
Yann> +include toolchain/binutils/binutils.mk
Yann> +include toolchain/ccache/ccache.mk
Yann> +include toolchain/elf2flt/elf2flt.mk
Yann> +include toolchain/gcc/gcc-uclibc-4.x.mk
Yann> +include toolchain/gdb/gdb.mk
Yann> +include toolchain/kernel-headers/kernel-headers.mk
Yann> +include toolchain/mklibs/mklibs.mk
Yann> +include toolchain/sstrip/sstrip.mk
Yann> +include toolchain/uClibc/uclibc.mk
Yann> diff --git a/toolchain/toolchain-external.mk b/toolchain/toolchain-external.mk
Yann> new file mode 100644
Yann> index 0000000..6c00330
Yann> --- /dev/null
Yann> +++ b/toolchain/toolchain-external.mk
Yann> @@ -0,0 +1,16 @@
Yann> +# Required includes for the external toolchain backend
Yann> +
Yann> +# Explicit ordering:
Yann> +include toolchain/helpers.mk
Yann> +include toolchain/binutils/binutils.mk
Yann> +include toolchain/ccache/ccache.mk
Yann> +include toolchain/dependencies/dependencies.mk
Yann> +include toolchain/elf2flt/elf2flt.mk
Yann> +include toolchain/gcc/gcc-uclibc-3.x.mk
Yann> +include toolchain/gcc/gcc-uclibc-4.x.mk
Yann> +include toolchain/gdb/gdb.mk
Yann> +include toolchain/toolchain-external/ext-tool.mk
Yann> +include toolchain/mklibs/mklibs.mk
Yann> +include toolchain/sstrip/sstrip.mk
Yann> +include toolchain/toolchain-external/ext-tool.mk
Yann> +include toolchain/uClibc/uclibc.mk
Why are the order of those includes not the same?
gcc-uclibc-3.x.mk is gone.
2x toolchain-external/ext-tool.mk?
Why do we need to include all these when using an external toolchain?
Most of them doesn't seem to make sense to me.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-06-27 21:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 22:15 [Buildroot] [PATCH 0/5] Preparatory work on toolchains - v2 Yann E. MORIN
2010-06-25 22:15 ` [Buildroot] [PATCH 1/5] toolchain: move helper functions from external toolchain Yann E. MORIN
2010-06-25 22:15 ` [Buildroot] [PATCH 2/5] toolchain: rename external toolchain dir Yann E. MORIN
2010-06-25 22:15 ` [Buildroot] [PATCH 3/5] toolchain: move makefile includes Yann E. MORIN
2010-06-27 21:06 ` Peter Korsgaard [this message]
2010-06-27 21:28 ` Yann E. MORIN
2010-06-25 22:15 ` [Buildroot] [PATCH 4/5] toolchain: move buildroot config files Yann E. MORIN
2010-06-25 22:15 ` [Buildroot] [PATCH 5/5] toolchain: rename base target for external toolchains Yann E. MORIN
2010-06-27 21:08 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2010-07-12 20:46 [Buildroot] [PATCH 0/5] Preparatory work on toolchains - v3 Yann E. MORIN
2010-07-12 20:46 ` [Buildroot] [PATCH 3/5] toolchain: move makefile includes Yann E. MORIN
2010-06-01 21:52 [Buildroot] [pull request] Preparatory work on toolchains Yann E. MORIN
2010-06-01 21:53 ` [Buildroot] [PATCH 3/5] toolchain: move makefile includes Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrtk2nin.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.