From: Kevin Hilman <khilman@deeprootsystems.com>
To: Nishanth Menon <nm@ti.com>
Cc: "G, Manjunath Kondaiah" <manjugk@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
"Kalliguddi, Hema" <hemahk@ti.com>,
Aaro Koskinen <Aaro.Koskinen@nokia.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v6] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt
Date: Wed, 28 Apr 2010 07:17:48 -0700 [thread overview]
Message-ID: <87wrvrhd9v.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4BD80867.7020801@ti.com> (Nishanth Menon's message of "Wed\, 28 Apr 2010 05\:05\:27 -0500")
Nishanth Menon <nm@ti.com> writes:
> very minor comments below:
> On 04/28/2010 12:47 AM, G, Manjunath Kondaiah wrote:
[...]
>> struct omap_i2c_dev {
>> struct device *dev;
>> @@ -199,6 +201,7 @@ struct omap_i2c_dev {
>> u16 bufstate;
>> u16 syscstate;
>> u16 westate;
>> + u16 errata;
> overall I'd prefer the term quirk over errata - quirk is more of a
> standard linux term used accross network, usb and other drivers, will
> allow the code to be a little more familiar with the upstream
> maintainers/reviewers.. but i leave it to tony and others to comment
> more.. maybe it is just me being an ass again ;)
I prefer the term errata since it is also the term used by TI docs.
Kevin
prev parent reply other threads:[~2010-04-28 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 5:47 [PATCH v6] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt Manjunatha GK
[not found] ` <1272433677-28658-1-git-send-email-manjugk-l0cyMroinI0@public.gmane.org>
2010-04-28 10:05 ` Nishanth Menon
[not found] ` <4BD80867.7020801-l0cyMroinI0@public.gmane.org>
2010-04-28 10:20 ` G, Manjunath Kondaiah
2010-04-28 10:22 ` Nishanth Menon
2010-04-28 14:17 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrvrhd9v.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=Aaro.Koskinen@nokia.com \
--cc=ben-linux@fluff.org \
--cc=hemahk@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.