From: dmonakhov@openvz.org
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/3] ext4: optimize quota write locking
Date: Mon, 05 Apr 2010 07:34:36 +0400 [thread overview]
Message-ID: <87wrwmy3lf.fsf@openvz.org> (raw)
In-Reply-To: <20100401091414.GF3322@quack.suse.cz> (Jan Kara's message of "Thu, 1 Apr 2010 11:14:14 +0200")
Jan Kara <jack@suse.cz> writes:
> On Sat 27-03-10 15:15:40, Dmitry Monakhov wrote:
>> Quota inode is append only. In most cases writes performed
>> to allocated blocks before i_size. Currently we grup i_mutex
>> for each quota write to protect i_size and i_mtime. But in most
>> cases i_size not changed. And i_mtime is not that important
>> as for regular files. So let's update it only when quota file
>> increased. This allow us to avoid i_mutex in most cases.
> But this won't help performance at all because dqio_mutex serializes
> writes to the file already, right?
Oops. This is true. It wasn't true in my private container's tree quota
implementation. So patch is not valid for common case. Please ignore it.
>
> Honza
next prev parent reply other threads:[~2010-04-05 3:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 12:15 [PATCH 0/3] ext4/quota: journalled quota optimizations Dmitry Monakhov
2010-03-27 12:15 ` [PATCH 1/3] quota: optimize mark_dirty logic Dmitry Monakhov
2010-03-27 12:15 ` [PATCH 2/3] ext4: journalled quota optimization Dmitry Monakhov
2010-03-27 12:15 ` [PATCH 3/3] ext4: optimize quota write locking Dmitry Monakhov
2010-04-01 9:14 ` Jan Kara
2010-04-05 3:34 ` dmonakhov [this message]
2010-04-01 9:12 ` [PATCH 2/3] ext4: journalled quota optimization Jan Kara
2010-04-05 3:30 ` dmonakhov
2010-04-06 18:06 ` Jan Kara
2010-04-07 8:12 ` Dmitry Monakhov
2010-04-07 12:06 ` Jan Kara
2010-03-31 15:06 ` [PATCH 1/3] quota: optimize mark_dirty logic Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrwmy3lf.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.