From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: jbaron@redhat.com, mingo@elte.hu, rostedt@goodmis.org,
fweisbec@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] dynamic debug - adding ring buffer storage support
Date: Tue, 22 Dec 2009 13:06:06 +0100 [thread overview]
Message-ID: <87ws0fcixd.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1261481526-17630-1-git-send-email-jolsa@redhat.com> (Jiri Olsa's message of "Tue, 22 Dec 2009 12:32:06 +0100")
Jiri Olsa <jolsa@redhat.com> writes:
> Hi,
>
> as I use dynamic debug sometimes, I thought it could be useful having
> the possibility to store the output somewhere else than dmesg.
>
> The attached patch implements support for storing dynamic debug
> messages to the ring buffer.
>
> The dynamic debug allows simple addition of new flags,
> so I added 'r' flag for ring buffer storage.
>
> I used the ring buffer implementation from trace framework.
>
> hopefuly this could be any use for others as well...
> plz let me know what you think,
The basic idea sounds good, but doing it all inline is a horrible
idea. That will bloat the kernel considerably because all
users have to expand this code.
I would suggest to implement an out of line dyndebug_printk()
which does all of this out of line.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-12-22 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 11:32 [RFC PATCH] dynamic debug - adding ring buffer storage support Jiri Olsa
2009-12-22 12:06 ` Andi Kleen [this message]
2009-12-22 15:28 ` Jiri Olsa
2009-12-22 15:39 ` Jason Baron
2009-12-22 16:13 ` Jiri Olsa
2009-12-28 9:24 ` Ingo Molnar
2009-12-30 22:50 ` Frederic Weisbecker
2009-12-31 1:44 ` Steven Rostedt
2010-01-05 15:14 ` Jason Baron
2010-01-05 6:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws0fcixd.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.