Re: FEATURES prints

[Kevin Hilman <khilman@deeprootsystems.com>]

Nishanth Menon <nm@ti.com> writes:

> Folks,
>
> With the addition of FEATURES in l-o, the following prints:
>  - l2cache : Y
>  - iva : Y
>  - sgx : Y
>  - neon : Y
>  - isp : Y
>
> comes up on SDP3430 -> now that we will introduce half a dozen
> features here and there, we will soon clutter this up. we should
> introduce a sysfs entry + remove the above noise..
>

Like Nishanth, I don't like the multi-line noise here.  The patch
below results in a single line output like this instead

OMAP3430/3530 ES3.0 (l2cache iva sgx neon isp )

Not sure why we need to dump features that are not there, but if that
s considered important, maybe prefixing each feature with a '+' or '-'
would still allow this to be collapsed into a single line.

Even with this, I think adding the display of these features into an
OMAP-specific section of /proc/cpuinfo would be even better.

Comments?

Kevin


commit 24f7422bad970cea2ed71d71e3994eeed70f175f
Author: Kevin Hilman <khilman@deeprootsystems.com>
Date:   Tue Oct 13 14:42:00 2009 -0700

    OMAP3: collapse chip feature prints to single line
    
    Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 71d5568..b90fcf1 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -249,11 +249,8 @@ void __init omap3_check_revision(void)
 }
 
 #define OMAP3_SHOW_FEATURE(feat)		\
-	if (omap3_has_ ##feat()) {		\
-		pr_info (" - "#feat" : Y");	\
-	} else {				\
-		pr_info (" - "#feat" : N");	\
-	}
+	if (omap3_has_ ##feat())		\
+		printk (#feat" ");      	\
 
 void __init omap3_cpuinfo(void)
 {
@@ -307,13 +304,14 @@ void __init omap3_cpuinfo(void)
 	/*
 	 * Print verbose information
 	 */
-	pr_info("OMAP%s ES%s\n", cpu_name, cpu_rev);
+	pr_info("OMAP%s ES%s (", cpu_name, cpu_rev);
 
 	OMAP3_SHOW_FEATURE(l2cache);
 	OMAP3_SHOW_FEATURE(iva);
 	OMAP3_SHOW_FEATURE(sgx);
 	OMAP3_SHOW_FEATURE(neon);
 	OMAP3_SHOW_FEATURE(isp);
+	printk(")\n");
 }
 
 /*