From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"hugh.dickins" <hugh.dickins@tiscali.co.uk>,
David Howells <dhowells@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [RFC][PATCH] kmap_atomic_push
Date: Mon, 12 Oct 2009 20:10:37 +0200 [thread overview]
Message-ID: <87ws30fppe.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1255016123.17055.17.camel@laptop> (Peter Zijlstra's message of "Thu, 08 Oct 2009 17:35:23 +0200")
Peter Zijlstra <peterz@infradead.org> writes:
> -
> -static inline void debug_kmap_atomic(enum km_type type)
> +static inline int kmap_atomic_push_idx(void)
> {
> + int idx = __get_cpu_var(__kmap_atomic_depth)++;
The counter needs to be of local atomic type. Otherwise kmap_atomic cannot
be done from interrupts/nmis, which is unfortunately occasionally needed.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-10-12 18:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 15:35 [RFC][PATCH] kmap_atomic_push Peter Zijlstra
2009-10-08 15:44 ` Linus Torvalds
2009-10-08 15:53 ` Ingo Molnar
2009-10-08 16:29 ` Peter Zijlstra
2009-10-08 16:50 ` Linus Torvalds
2009-10-08 18:02 ` Hugh Dickins
2009-10-08 22:27 ` jim owens
2009-10-08 22:32 ` Peter Zijlstra
2009-10-08 22:57 ` Peter Zijlstra
2009-10-09 12:15 ` jim owens
2009-10-08 22:12 ` David Howells
2009-10-08 22:29 ` Peter Zijlstra
2009-10-08 22:58 ` David Howells
2009-10-08 22:42 ` Peter Zijlstra
2009-10-08 22:42 ` Peter Zijlstra
2009-10-12 18:10 ` Andi Kleen [this message]
2009-10-12 18:30 ` Linus Torvalds
2009-10-12 18:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws30fppe.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.