From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvW7n-0000iU-7B
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:00:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvW7i-0000eY-KL
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:00:10 -0400
Received: from [199.232.76.173] (port=40337 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvW7i-0000eJ-G2
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:00:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14407)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MvW7h-000835-Pe
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:00:06 -0400
Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: {} as in linux kernel
References: <20091006190115.GA4768@redhat.com>
	<4ACBB1B5.7010704@mail.berlios.de> <4ACBBA0E.7040905@codemonkey.ws>
From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 07 Oct 2009 14:59:58 +0200
In-Reply-To: <4ACBBA0E.7040905@codemonkey.ws> (Anthony Liguori's message of
	"Tue\, 06 Oct 2009 16\:43\:42 -0500")
Message-ID: <87ws37z7e9.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

Anthony Liguori <anthony@codemonkey.ws> writes:

> Stefan Weil wrote:
>> Michael S. Tsirkin schrieb:
>>   
>>> Most people seem to hate using {} around sngle-statement blocks.
>>> And code isn't consistent either way. So let's change our standard
>>> to something most people like, and eliminate the pain source.
>>>
>>>       
>>
>> Inconsistency is not an argument for or against {}.
>> I don't like single statement blocks without {}
>> because of my personal experience with all kinds
>> of code standard variants.
>>
>> Please don't change the qemu standard, I like it as it is.
>>   
>
> I've never liked this but I would rather not see unnecessary churn so
> I'd prefer to keep the coding style as-is.

The existing code uses both brace styles.  We didn't convert it
wholesale when the "thou shalt use braces" rule was written into the
coding style, because we didn't want the churn.  We can handle it just
the same now.  Churn is not an argument then.

I dislike redundant braces, and support the change Michael proposed.