Re: [PATCH v3 02/04] OMAP4: PMIC: Add support for twl6030 RTC

[Kevin Hilman <khilman@deeprootsystems.com>]

balajitk@ti.com writes:

> From: Balaji T K <balajitk@ti.com>
>
> This version of patch series enables RUN TIME selection of TWL4030 or TWL6030.
>
> This patch adds support for RTC in phoenix TWL6030.
> Register offset addresses have changed in TWL6030
> rtc-twl.c will hence forth support all twl RTC (4030, 5030, 6030 ..)
>
> Signed-off-by: Balaji T K <balajitk@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Reviewed-by: Tony Lindgren <tony@atomide.com>

[...]

> @@ -352,6 +401,7 @@ static irqreturn_t twl_rtc_interrupt(int irq, void *rtc)
>  	if (res)
>  		goto out;
>  
> +if (twl_class_is_4030()) {

indentation?

>  	/* Clear on Read enabled. RTC_IT bit of TWL4030_INT_PWR_ISR1
>  	 * needs 2 reads to clear the interrupt. One read is done in
>  	 * do_twl_pwrirq(). Doing the second read, to clear
> @@ -367,6 +417,7 @@ static irqreturn_t twl_rtc_interrupt(int irq, void *rtc)
>  			&rd_reg, TWL4030_INT_PWR_ISR1);
>  	if (res)
>  		goto out;
> +}

and here?

after that,

Reviewed-by: Kevin Hilman <khilman@deeprootsystems.com>