Re: [PATCH] RFC: ASoC: Davinci: Fix data_type divide by zero

[Kevin Hilman <khilman@deeprootsystems.com>]

Mark Brown <broonie@opensource.wolfsonmicro.com> writes:

> On Fri, Sep 11, 2009 at 02:27:18PM -0700, Troy Kisky wrote:
>> Mark Brown wrote:
>
>> >> +	 * dma_params must be first because rtd->dai->cpu_dai->private_data
>> >> +	 * is cast to an array of struct davinci_pcm_dma_params ** in
>> >> +	 * davinci_pcm_open.
>> >> +	 */
>
>> > Is it not possible to deal with this by going through the types
>> > properly?  The comment sets off all sorts of alarm bells.
>
>> private_data will be either struct davinci_mcbsp_dev or
>> struct davinci_audio_dev
>
> Hrm.  Might be nice to change that :/
>
>> Btw, I'm about to submit another rev of this against your for32
>> branch. But your branch currently give compile errors, so it
>> my compile test just doesn't generate new errors.
>
> You'll need to merge it with Kevin's branch to build - or wait for -rc1
> when everything should've made it into mainline.  Kevin's git has a
> branch temp/asoc with the merge done in it.

Also, I just pushed a new temp/asoc which is a simple merge of current
davinci git master and Mark's for-2.6.32 branch.

Kevin