From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] vgcfgbackup: do not produce corrupted metadata if PVs are missing
Date: Tue, 19 May 2009 07:53:39 +0200 [thread overview]
Message-ID: <87ws8dbpuk.fsf@mornfall.net> (raw)
In-Reply-To: <4A0D7D6F.4020103@redhat.com> (Milan Broz's message of "Fri, 15 May 2009 16:34:23 +0200")
Milan Broz <mbroz@redhat.com> writes:
> Currently code uses pv_dev_name() for hash when getting internal
> "pvX" name.
>
> This produce corrupted metadata if PVs are missing, pv->dev
> is NULL and all these missing devices returns one name
> (using "unknown device" for all missing devices as hash key).
Good catch. Patch looks good (and comes with a test).
> Signed-off-by: Milan Broz <mbroz@redhat.com>
Acked-By: Petr Rockai <prockai@redhat.com>
--
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentation
prev parent reply other threads:[~2009-05-19 5:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 14:34 [PATCH] vgcfgbackup: do not produce corrupted metadata if PVs are missing Milan Broz
2009-05-19 5:53 ` Petr Rockai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws8dbpuk.fsf@mornfall.net \
--to=prockai@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.