From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LwBLg-0007An-8k
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:29:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LwBLf-0007AN-Le
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:28:59 -0400
Received: from [199.232.76.173] (port=51826 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LwBLf-0007AE-Gi
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:28:59 -0400
Received: from lechat.rtp-net.org ([88.191.19.38]:56898)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <arnaud.patard@rtp-net.org>) id 1LwBLf-0003PS-64
	for qemu-devel@nongnu.org; Tue, 21 Apr 2009 04:28:59 -0400
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
Subject: Re: [Qemu-devel] [7118] linux-user: prefer glibc over direct syscalls
References: <E1Lu7ig-0007Ez-1h@cvs.savannah.gnu.org>
	<761ea48b0904210056w37100e85tcf71162c84e961d1@mail.gmail.com>
Date: Tue, 21 Apr 2009 10:36:13 +0200
In-Reply-To: <761ea48b0904210056w37100e85tcf71162c84e961d1@mail.gmail.com>
	(Laurent Desnogues's message of "Tue\,
	21 Apr 2009 09\:56\:12 +0200")
Message-ID: <87ws9ee742.fsf@lechat.rtp-net.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-devel@nongnu.org

Laurent Desnogues <laurent.desnogues@gmail.com> writes:

Hi,

>> +#ifdef TARGET_NR_utimensat
>> +static int sys_utimensat(int dirfd, const char *pathname,
>> + =C2=A0 =C2=A0const struct timespec times[2], int flags)
>> +{
>> + =C2=A0return (utimensat(dirfd, pathname, times, flags));
>> +}
>> +#endif
>
> Just to point that my system has all *at functions except for utimensat=
.
> This breaks compilation.  Shouldn't all *at functions be tested in the
> configure script?

This utimensat change is broken, I've sent a patch to revert to the
syscall interface. As a side effect, it'll bring back the check :

#if defined(TARGET_NR_utimensat) && defined(__NR_utimensat)

It will likely solve your trouble. Lets hope the patch will be merged :)

>
> For the record I am running CentOS 5.3 x86_64.

hmm... glibc older than 2.6 or kernel older than 2.6.22 ?

Arnaud