From: Kalle Valo <kalle.valo@iki.fi>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] at76_usb: fix Oops on disconnect
Date: Wed, 18 Feb 2009 22:52:19 +0200 [thread overview]
Message-ID: <87wsbnpiws.fsf@litku.valot.fi> (raw)
In-Reply-To: <c4d76b3b0902081947x92eb0bo73fa63afb23b5e2c@mail.gmail.com> (Jason Andryuk's message of "Sun\, 8 Feb 2009 22\:47\:32 -0500")
Jason Andryuk <jandryuk@gmail.com> writes:
> I'll take a look at at76c50x-usb in general and bringing over this
> patch specifically. Unfortunately, I still had one disconnect oops
> with the patch installed. Netconsole was not configured, so I did not
> catch it. There were several other successful disconnects without
> Oops though.
Progress is always good :)
> It may need locking as none is currently present, but does a one way
> transition device_unplugged 0 -> 1 need a lock?
Using int might be enough but I think it's not guarenteed anywhere.
Better to use atomic operations directly or use a proper lock. But I
think the issues are more than that. For example, the disconnect
handler is not taking the mutex.
--
Kalle Valo
next prev parent reply other threads:[~2009-02-18 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 4:03 [PATCH] at76_usb: fix Oops on disconnect Jason Andryuk
2009-02-07 11:29 ` Kalle Valo
2009-02-09 3:47 ` Jason Andryuk
2009-02-18 20:52 ` Kalle Valo [this message]
2009-02-19 3:25 ` [PATCH] at76c50x-usb: additional disconnect fixes Jason Andryuk
2009-02-19 6:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wsbnpiws.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=jandryuk@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.