From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTDQC-0006k4-IY for mharc-grub-devel@gnu.org; Wed, 13 Aug 2008 06:17:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTDQ8-0006jR-Fn for grub-devel@gnu.org; Wed, 13 Aug 2008 06:17:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTDQ5-0006il-Fl for grub-devel@gnu.org; Wed, 13 Aug 2008 06:17:35 -0400 Received: from [199.232.76.173] (port=52195 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTDQ4-0006ic-Jk for grub-devel@gnu.org; Wed, 13 Aug 2008 06:17:33 -0400 Received: from smtp-vbr6.xs4all.nl ([194.109.24.26]:2981) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTDQ4-00048Y-2g for grub-devel@gnu.org; Wed, 13 Aug 2008 06:17:32 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr6.xs4all.nl (8.13.8/8.13.8) with ESMTP id m7DAHUNg017157 for ; Wed, 13 Aug 2008 12:17:31 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <39131.89.103.133.237.1218141734.squirrel@mail.netbsd.sk> <35247.89.103.133.237.1218178352.squirrel@mail.netbsd.sk> Mail-Copies-To: mgerards@xs4all.nl Date: Wed, 13 Aug 2008 12:21:07 +0200 In-Reply-To: <35247.89.103.133.237.1218178352.squirrel@mail.netbsd.sk> (lkundrak@v3.sk's message of "Fri, 8 Aug 2008 02:52:32 -0400 (EDT)") Message-ID: <87wsil8bcc.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Do not mess with libc's prototypes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 10:17:36 -0000 lkundrak@v3.sk writes: > Due to some more breakage, here's some more patch: > > According to POSIX memmove and memcpy can actually be macros or whatever > (IIRC). We'd better not play with those in code that uses libc's headers > and is to be linked with libc. > > 2008-08-08 Lubomir Rintel > > * include/grub/misc.h: Surround memmove and memcpy prototypes with > #ifndef GRUB_UTIL > * kern/misc.c: Surround memmove, memcpy and memset prototypes with > #ifndef GRUB_UTIL This is not for GRUB_UTIL, so please don't do this. Perhaps your problem can be fixed in another way. IIRC, this was added because on the PPC, memcpy was required by libgcc, which is used there... -- Marco