From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQJrE-0002pe-3a for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 06:33:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQJr9-0002oJ-PZ for grub-devel@gnu.org; Tue, 05 Aug 2008 06:33:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQJr8-0002md-Bb for grub-devel@gnu.org; Tue, 05 Aug 2008 06:33:30 -0400 Received: from [199.232.76.173] (port=48368 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQJr7-0002mQ-W3 for grub-devel@gnu.org; Tue, 05 Aug 2008 06:33:30 -0400 Received: from smtp-vbr8.xs4all.nl ([194.109.24.28]:1683) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQJr7-0007c4-Gs for grub-devel@gnu.org; Tue, 05 Aug 2008 06:33:29 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr8.xs4all.nl (8.13.8/8.13.8) with ESMTP id m75AXShn069791 for ; Tue, 5 Aug 2008 12:33:28 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Aug 2008 12:36:06 +0200 In-Reply-To: (bean123ch@gmail.com's message of "Sat, 26 Jul 2008 00:38:59 +0800") Message-ID: <87wsivg355.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Misc patches for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 10:33:32 -0000 Hi, Bean writes: > This is a collection of miscellaneous patches, it includes: Please do not collect patches. Independant changes can better go into independant patches. Mails like this are easily overseen and so are important changes made by such patch. > 1, move util/envblk.c to lib/envblk.c > > As envblk.c is used by module loadenv and tool grub-editenv, I think > it's better to move it to lib directory. For some reason I have some doubts about lib/. But I do not have a better name in mind either. What does belong in there? Do you happen to have other names in mind as a suggestion? :-) > 2. seperate hexdump function, and move it to lib/hexdump.c > > hexdump module consists of two parts, one is hexdump function, the > other is user land command. I move the hexdump function to lib, as > it's also used in other place, for example grub-fstest. Same here :-) > 3. add new command crc > > Just like hexdump, this module is split into two parts, lib/crc.c for > the crc function, commands/crc.c for the user land command that > calculate the crc checksum of selected file. If it is for users, it should go into util/ When and how is it used? > 4. rename appleloader command to bootcamp > > The name appleloader may be a little confusing, bootcamp seems to be a > better choice. How about legacyloader or even legacy? Isn't that what it does without actually using possibly trademarked names people are afraid of using? -- Marco