From: Johannes Weiner <hannes@saeurebad.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Remove redundant display of free swap space in show_mem()
Date: Mon, 10 Mar 2008 19:47:02 +0100 [thread overview]
Message-ID: <87wsoa76xl.fsf@saeurebad.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0803101720580.3398@blonde.site> (Hugh Dickins's message of "Mon, 10 Mar 2008 17:28:37 +0000 (GMT)")
Hi,
Hugh Dickins <hugh@veritas.com> writes:
> On Mon, 10 Mar 2008, Johannes Weiner wrote:
>> From: Johannes Weiner <hannes@saeurebad.de>
>>
>> show_free_areas() already displays free swap space, no need to do it a
>> second time in show_mem() which calls the former anyway.
>>
>> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
>
> I heartily approve of this; and yes, it's the per-arch one which should
> go (since its "alignment" looks nasty). But there's a lot more arches
> than just x86 which should be fixed (and so rather more work, preparing
> those patches for the various maintainers) - is that something you'd
> have time to do? (Don't worry, "No" is a perfectly fair answer, and
> it's no way essential that all change at once.)
Yes, I will whip something up. Thanks for the feedback.
Hannes
next prev parent reply other threads:[~2008-03-10 18:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 16:40 [PATCH] x86: Remove redundant display of free swap space in show_mem() Johannes Weiner
2008-03-10 17:28 ` Hugh Dickins
2008-03-10 18:47 ` Johannes Weiner [this message]
2008-03-11 9:14 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-03-10 20:10 [PATCH] arm: " Johannes Weiner
2008-03-10 20:10 ` [PATCH] x86: " Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wsoa76xl.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.