From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHg24-0007ce-Uq for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 08:52:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHg23-0007a1-3E for grub-devel@gnu.org; Wed, 23 Jan 2008 08:52:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHg1z-0007UP-KF for grub-devel@gnu.org; Wed, 23 Jan 2008 08:52:46 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHg1z-0007UG-Fe for grub-devel@gnu.org; Wed, 23 Jan 2008 08:52:43 -0500 Received: from smtp-vbr3.xs4all.nl ([194.109.24.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JHg1z-0000jk-5N for grub-devel@gnu.org; Wed, 23 Jan 2008 08:52:43 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr3.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0NDqf7w057444 for ; Wed, 23 Jan 2008 14:52:42 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080123131855.GA29373@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Wed, 23 Jan 2008 14:53:58 +0100 In-Reply-To: <20080123131855.GA29373@thorin> (Robert Millan's message of "Wed, 23 Jan 2008 14:18:55 +0100") Message-ID: <87wsq0odft.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] use of grub_dprintf in grub_mm_init_region() is misleading X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 13:52:47 -0000 Robert Millan writes: > Using grub_dprintf() in grub_mm_init_region() easily leads to think that one > can activate this debug message by issuing `grub_env_set ("debug", "mem")' in > grub_machine_init(), before memory initialisation. > > However, that's completely false. grub_env_set will silently [1] ignore your > call because grub_malloc() ain't usable, possibly making you think for a while > that no free memory was found, and that memory was not initialized at all! > > I propose turning it into a disabled grub_printf(). Fine for me. -- Marco