From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHdIi-0005ZX-Sz for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 05:57:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHdIg-0005WF-F6 for grub-devel@gnu.org; Wed, 23 Jan 2008 05:57:46 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHdIe-0005Sb-BT for grub-devel@gnu.org; Wed, 23 Jan 2008 05:57:45 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHdId-0005SR-UL for grub-devel@gnu.org; Wed, 23 Jan 2008 05:57:43 -0500 Received: from smtp-vbr14.xs4all.nl ([194.109.24.34]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JHdId-0008AI-G0 for grub-devel@gnu.org; Wed, 23 Jan 2008 05:57:43 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr14.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0NAvgIH008320 for ; Wed, 23 Jan 2008 11:57:42 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080123104737.GA24943@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Wed, 23 Jan 2008 11:58:58 +0100 In-Reply-To: <20080123104737.GA24943@thorin> (Robert Millan's message of "Wed, 23 Jan 2008 11:47:37 +0100") Message-ID: <87wsq0reod.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] use at_keyboard.c on i386-ieee1275 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 10:57:46 -0000 Robert Millan writes: > Taking into account that ofconsole on i386: > > - Has bugs with similar usability effect than at_keyboard.c (e.g. arrow keys > not working). > - In practice doesn't provide support for any keyboard other than AT > (since OFW shuts down USB before transfering control to us). > - Sharing code with other ports (CoreBoot, attow) is more efficient to get > these bugs solved. > > I propose to use at_keyboard.c as default for i386-ieee1275. Fine for me, it is your baby :-) Although you forgot the changelog entry. Will you fix the ifdef's soon? Doesn't this cause any problems? Now there are two keyboard drivers active. -- Marco