All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu SEGAUD <mathieu.segaud@regala.cx>
To: linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sct@redhat.com
Subject: Re: [PATCH] Convert ext3_ioctl() to an unlocked_ioctl
Date: Fri, 18 Jan 2008 00:48:29 +0100	[thread overview]
Message-ID: <87wsq89foy.fsf@barad-dur.regala.cx> (raw)
In-Reply-To: <1200573450-1246-2-git-send-email-mathieu.segaud@regala.cx> (Mathieu Segaud's message of "Thu\, 17 Jan 2008 13\:37\:29 +0100")

Vous m'avez dit récemment :

> --- a/fs/ext3/ioctl.c
> +++ b/fs/ext3/ioctl.c
> @@ -17,12 +17,19 @@
>  #include <linux/smp_lock.h>
>  #include <asm/uaccess.h>
>  
> -int ext3_ioctl (struct inode * inode, struct file * filp, unsigned int cmd,
> +long ext3_ioctl(struct file *filp, unsigned int cmd,
>  		unsigned long arg)
>  {
> -	struct ext3_inode_info *ei = EXT3_I(inode);
> +	struct ext3_inode_info *ei;
> +	struct inode *inode;
>  	unsigned int flags;
>  	unsigned short rsv_window_size;
> +	long retval = 0;
> +
> +	lock_kernel();
> +
> +	inode = filp->f_dentry->d_inode;

I guess this should be
        inode = filp->f_path.dentry->d_inode;


I will repost a fixed patch
sorry for this one.


> +	ei = EXT3_I(inode);
>  
>  	ext3_debug ("cmd = %u, arg = %lu\n", cmd, arg);
>  

-- 
Mathieu

  parent reply	other threads:[~2008-01-17 23:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 12:37 [PATCH] Convert EXT2 to use unlocked_ioctl Mathieu Segaud
2008-01-17 12:37 ` [PATCH] Convert ext3_ioctl() to an unlocked_ioctl Mathieu Segaud
2008-01-17 12:37   ` [PATCH] Convert ext4_ioctl " Mathieu Segaud
2008-01-17 23:50     ` Mathieu SEGAUD
2008-01-17 23:48   ` Mathieu SEGAUD [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-22 13:09 [RESENT] Fix previously extX_ioctl() patches Mathieu Segaud
2008-01-22 13:09 ` [PATCH] Convert ext4_ioctl to an unlocked_ioctl Mathieu Segaud
2008-01-22 13:09   ` [PATCH] Convert ext3_ioctl() " Mathieu Segaud
2008-01-17 10:30 [PATCH] Convert EXT2 to use unlocked_ioctl Mathieu Segaud
2008-01-17 10:30 ` [PATCH] Convert ext3_ioctl() to an unlocked_ioctl Mathieu Segaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wsq89foy.fsf@barad-dur.regala.cx \
    --to=mathieu.segaud@regala.cx \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.