From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ItiMh-0005T6-SY for mharc-grub-devel@gnu.org; Sun, 18 Nov 2007 06:31:03 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ItiMf-0005Sn-Qi for grub-devel@gnu.org; Sun, 18 Nov 2007 06:31:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ItiMe-0005SG-HF for grub-devel@gnu.org; Sun, 18 Nov 2007 06:31:01 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItiMe-0005S7-4v for grub-devel@gnu.org; Sun, 18 Nov 2007 06:31:00 -0500 Received: from smtp-vbr10.xs4all.nl ([194.109.24.30]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ItiMZ-0003GK-KH for grub-devel@gnu.org; Sun, 18 Nov 2007 06:30:56 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr10.xs4all.nl (8.13.8/8.13.8) with ESMTP id lAIBTsCg024359 for ; Sun, 18 Nov 2007 12:29:54 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <473A0C32.5000001@t-online.de> Mail-Copies-To: mgerards@xs4all.nl Date: Sun, 18 Nov 2007 12:30:49 +0100 In-Reply-To: <473A0C32.5000001@t-online.de> (Christian Franke's message of "Tue, 13 Nov 2007 21:42:26 +0100") Message-ID: <87wssfrdsm.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] mkdevicemap for Cygwin X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2007 11:31:02 -0000 Christian Franke writes: > Some changes for grub-mkdevicemap on Cygwin. > > Christian > > 2007-11-13 Christian Franke > > * util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin > device names. > (get_ide_disk_name): Disable on __CYGWIN__. [__CYGWIN__] (get_ide_disk_name): Disable. > (get_scsi_disk_name): Add Cygwin device names. > (check_device): Add static. > Return error instead of success on empty string. Can you explain this? Does this break something on GNU/Linux? > (make_device_map): Disable IDE loop on __CYGWIN__. [__CYGWIN__] (make_device_map): Disable IDE loop. > Move label inside linux specific code to prevent compiler warning. (make_device_map): Move label inside linux specific code to prevent compiler warning. Otherwise fine, so this can be committed if there aren't any other problems with this patch. -- Marco