From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1I27Ii-0003Sc-Rr for mharc-grub-devel@gnu.org; Sat, 23 Jun 2007 11:13:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I27Ig-0003SJ-Kk for grub-devel@gnu.org; Sat, 23 Jun 2007 11:13:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I27Id-0003RP-9H for grub-devel@gnu.org; Sat, 23 Jun 2007 11:13:21 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I27Id-0003RM-4O for grub-devel@gnu.org; Sat, 23 Jun 2007 11:13:19 -0400 Received: from smtp-vbr8.xs4all.nl ([194.109.24.28]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I27Ic-0005Mk-Ki for grub-devel@gnu.org; Sat, 23 Jun 2007 11:13:18 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr8.xs4all.nl (8.13.8/8.13.8) with ESMTP id l5NFDHvQ057104 for ; Sat, 23 Jun 2007 17:13:18 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20070623115827.GA27818@aragorn> <87ejk2onps.fsf@xs4all.nl> <20070623144640.GA32281@aragorn> Mail-Copies-To: mgerards@xs4all.nl Date: Sat, 23 Jun 2007 17:13:35 +0200 In-Reply-To: <20070623144640.GA32281@aragorn> (Robert Millan's message of "Sat, 23 Jun 2007 16:46:40 +0200") Message-ID: <87wsxun1pc.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Subject: Re: serial module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2007 15:13:22 -0000 Robert Millan writes: > On Sat, Jun 23, 2007 at 02:32:47PM +0200, Marco Gerards wrote: >> >> You forgot a changelog entry :-/ > > How about.. > > * conf/i386-pc.rmk: (pkgdata_MODULES): Add serial.mod. Good, except for the first ":". [...] >> The same is true for cpuid, I think. Are >> you sure it works in grub-emu? > > Yes, cpuid should work everywhere as long as your cpu supports it. Oh, nice :-). I should try it :-). >> Please test if it still builds, when >> adding stuff. > > Sure (I even tested that it runs and sets up the serial console correctly). I meant testing grub-emu. It is disabled by default, so you might not notice breaking it, when you do. >> > disk/loopback.c disk/raid.c disk/lvm.c \ >> > fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \ >> > fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \ >> > @@ -131,7 +131,7 @@ >> > pkgdata_MODULES = _chain.mod _linux.mod linux.mod normal.mod \ >> > _multiboot.mod chain.mod multiboot.mod reboot.mod halt.mod \ >> > vbe.mod vbetest.mod vbeinfo.mod video.mod gfxterm.mod \ >> > - videotest.mod play.mod bitmap.mod tga.mod cpuid.mod >> > + videotest.mod play.mod bitmap.mod tga.mod cpuid.mod serial.mod >> >> Good catch, I also wonder why this wasn't added. Can you please apply >> this change? > > Done. Thanks a lot. -- Marco