From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EqpKi-0000x1-5s for mharc-grub-devel@gnu.org; Mon, 26 Dec 2005 05:12:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EqpKc-0000tx-J2 for grub-devel@gnu.org; Mon, 26 Dec 2005 05:11:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EqpKb-0000tC-60 for grub-devel@gnu.org; Mon, 26 Dec 2005 05:11:53 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EqpKa-0000sn-Gh for grub-devel@gnu.org; Mon, 26 Dec 2005 05:11:52 -0500 Received: from [194.109.24.30] (helo=smtp-vbr10.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EqpKO-0001hA-2M for grub-devel@gnu.org; Mon, 26 Dec 2005 05:11:40 -0500 Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by smtp-vbr10.xs4all.nl (8.13.3/8.13.3) with ESMTP id jBQAAXsA098779 for ; Mon, 26 Dec 2005 11:10:34 +0100 (CET) (envelope-from mgerards@xs4all.nl) Mail-Copies-To: mgerards@xs4all.nl To: The development of GRUB 2 References: <43AF483C.2080102@nic.fi> From: Marco Gerards Date: Mon, 26 Dec 2005 11:10:33 +0100 In-Reply-To: <43AF483C.2080102@nic.fi> (Vesa =?iso-8859-1?Q?J=E4=E4skel=E4?= =?iso-8859-1?Q?inen's?= message of "Mon, 26 Dec 2005 03:32:44 +0200") Message-ID: <87wths88yu.fsf@xs4all.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by XS4ALL Virus Scanner Subject: Re: Need for VBE helper functions? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2005 10:11:57 -0000 Vesa J=E4=E4skel=E4inen writes: Hi Vesa, > I have been making video driver for VBE and currently at beginning of > that file there are codes for those VBE helpers defined in > (include/grub/i386/pc/vbe.h). As I had some issues with mixing them with > each other I renamed all kernel stubs like from grub_vbe_* to > grub_vbe_bios_* so they cannot be easily mixed. > > I was thinking that is there a still need to have those helper functions > at all there? If they will be there I will use them from driver code, if > not, I will integrate the functionality to driver code. By integrating > the code to driver it would make that driver file more easier to read, > but then we lose option to use those helpers directly. One option is to > move them elsewhere, but then there is a problem what is the module name > and where. So what you have now is some VBE functions and a video driver and you are wondering if they should be merged? I think that shouldn't be done because multiboot should also use VBE to switch video modes. > I will update shortly (tomorrow most likely) wiki with results of the > newest API design round. After I think it is correct I will concentrate > on enhancing the terminal code to make use of newly added functionality. Cool! Thanks, Marco