From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1DEabk-0004Yk-3l
	for mharc-grub-devel@gnu.org; Thu, 24 Mar 2005 17:15:16 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DEabT-0004UH-0S
	for grub-devel@gnu.org; Thu, 24 Mar 2005 17:14:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DEabH-0004QY-3v
	for grub-devel@gnu.org; Thu, 24 Mar 2005 17:14:47 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DEabG-0004MY-Hu
	for grub-devel@gnu.org; Thu, 24 Mar 2005 17:14:46 -0500
Received: from [145.74.66.11] (helo=mail-cn.han.nl)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DEa5I-0006Me-U8
	for grub-devel@gnu.org; Thu, 24 Mar 2005 16:41:45 -0500
Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6])
	by mail-cn.han.nl (Postfix) with ESMTP id 7548D9DC5
	for <grub-devel@gnu.org>; Thu, 24 Mar 2005 22:41:43 +0100 (CET)
Received: from mail-cn.han.nl ([145.74.66.11])
	by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new,
	port 10024) with ESMTP id 00579-07 for <grub-devel@gnu.org>;
	Thu, 24 Mar 2005 22:41:41 +0100 (CET)
Received: from mail1.han.nl (mail1.han.nl [145.74.103.11])
	by mail-cn.han.nl (Postfix) with ESMTP id 5F8519DC2
	for <grub-devel@gnu.org>; Thu, 24 Mar 2005 22:41:41 +0100 (CET)
Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129])
	by mail1.han.nl (Postfix) with ESMTP id 2A0CEC045
	for <grub-devel@gnu.org>; Thu, 24 Mar 2005 22:41:41 +0100 (CET)
Mail-Copies-To: metgerards@student.han.nl
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20050324030054.GA21271@miracle>
From: Marco Gerards <metgerards@student.han.nl>
Date: Thu, 24 Mar 2005 22:41:42 +0100
In-Reply-To: <20050324030054.GA21271@miracle> (Hollis Blanchard's message of
	"Wed, 23 Mar 2005 21:00:54 -0600")
Message-ID: <87wtrwvi09.fsf@student.han.nl>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl
Subject: Re: [patch] PPC build fixes
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2005 22:15:05 -0000

Hollis Blanchard <hollis@penguinppc.org> writes:

> 5 weeks later...

np.

> Here I did not combine i386 and PPC halt/reboot as I did in my original
> patch.

Cool!

> 	(grub_halt_init): New function.
> 	(grub_halt_fini): Likewise.

Why do you need this?

> 	(grub_reboot_init): New function.
> 	(grub_reboot_fini): Likewise.

Same here.

> 	* include/grub/powerpc/ieee1275/init.h: Remove inaccurate
> 	comment.

Can you change the comment to something sane?

> 	* util/powerpc/ieee1275/misc.c (grub_reboot): New function.
> 	(grub_halt): Likewise.

Isn't this just a completely new file?

Thanks,
Marco