From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: "Nerijus Bendžiūnas" <nerijus.bendziunas@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
"John W . Linville" <linville@tuxdriver.com>,
Simon Wunderlich <sw@simonwunderlich.de>,
Oleksij Rempel <linux@rempel-privat.de>,
Kalle Valo <kvalo@kernel.org>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH ath-next v4 6/8] wifi: ath9k: count spectral samples in the driver's own RX stats
Date: Mon, 19 Oct 2026 21:19:03 +0200 [thread overview]
Message-ID: <87y0btv6qg.fsf@toke.dk> (raw)
In-Reply-To: <20260916173429.403889-7-nerijus.bendziunas@gmail.com>
Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com> writes:
> ath_cmn_process_fft() is shared by ath9k and ath9k_htc, but it casts
> common->priv to struct ath_softc to reach the rx_spectral_sample_good
> and rx_spectral_sample_err counters. On ath9k_htc common->priv is a
> struct ath9k_htc_priv, a much smaller structure, and with
> CONFIG_ATH9K_DEBUGFS the increment lands far past the end of that
> allocation, once per FFT sample.
>
> Store a pointer to the driver's struct ath_rx_stats in struct
> ath_spec_scan_priv and count through it. Both drivers pass their own
> stats to ath9k_cmn_spectral_init_debug(), and both print them in the
> shared recv debugfs file, so the two counters now also work on
> ath9k_htc. Without debugfs the pointer stays NULL and nothing is
> counted, as before.
>
> Fixes: 03224678c013 ("ath9k: add counters for good and errorneous FFT/spectral frames")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Nerijus Bendžiūnas <nerijus.bendziunas@gmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
next prev parent reply other threads:[~2026-10-19 19:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 17:34 [PATCH ath-next v4 0/8] wifi: ath9k: fix register access and spectral scan filter handling on ath9k_htc Nerijus Bendžiūnas
2026-09-16 17:34 ` [PATCH ath-next v4 1/8] wifi: ath9k: return an error from a failed multi-register read Nerijus Bendžiūnas
2026-10-19 19:17 ` Toke Høiland-Jørgensen
2026-09-16 17:34 ` [PATCH ath-next v4 2/8] wifi: ath9k_htc: fix the byte count of a full RMW buffer flush Nerijus Bendžiūnas
2026-10-19 19:18 ` Toke Høiland-Jørgensen
2026-09-16 17:34 ` [PATCH ath-next v4 3/8] wifi: ath9k_htc: refuse a command that fills whole USB packets Nerijus Bendžiūnas
2026-10-19 19:18 ` Toke Høiland-Jørgensen
2026-09-16 17:34 ` [PATCH ath-next v4 4/8] wifi: ath9k: stop a failed register read from opening the RX filter Nerijus Bendžiūnas
2026-10-19 19:18 ` Toke Høiland-Jørgensen
2026-09-16 17:34 ` [PATCH ath-next v4 5/8] wifi: ath9k: clear the PHY error filter when a spectral scan is disabled Nerijus Bendžiūnas
2026-10-19 19:18 ` Toke Høiland-Jørgensen
2026-09-16 17:34 ` [PATCH ath-next v4 6/8] wifi: ath9k: count spectral samples in the driver's own RX stats Nerijus Bendžiūnas
2026-10-19 19:19 ` Toke Høiland-Jørgensen [this message]
2026-09-16 17:34 ` [PATCH ath-next v4 7/8] wifi: ath9k_htc: pass CRC-tagged spectral samples to the FFT parser Nerijus Bendžiūnas
2026-10-19 19:19 ` Toke Høiland-Jørgensen
2026-09-16 17:34 ` [PATCH ath-next v4 8/8] wifi: ath9k_htc: derive the PHY error filter bits from software state Nerijus Bendžiūnas
2026-10-19 19:19 ` Toke Høiland-Jørgensen
2026-09-29 16:30 ` [PATCH ath-next v4 0/8] wifi: ath9k: fix register access and spectral scan filter handling on ath9k_htc Nerijus Bendžiūnas
2026-09-30 7:49 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0btv6qg.fsf@toke.dk \
--to=toke@toke.dk \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=linville@tuxdriver.com \
--cc=nerijus.bendziunas@gmail.com \
--cc=stable@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.