All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Julius Bairaktaris <julius@bairaktaris.de>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v1] wifi: mac80211: fix swapped fq_overlimit/fq_overmemory in aqm debugfs
Date: Mon, 24 Aug 2026 12:44:59 +0200	[thread overview]
Message-ID: <87y0dver10.fsf@toke.dk> (raw)
In-Reply-To: <20260823195739.49222-1-julius@bairaktaris.de>

Julius Bairaktaris <julius@bairaktaris.de> writes:

> The aqm file prints fq_overlimit with fq->overmemory and fq_overmemory
> with fq->overlimit. The fq_overmemory line was added to the format string
> after fq_overlimit while its argument went in before it, and the two have
> been crossed since.
>
> The counters are not interchangeable: fq_tin_enqueue() bumps fq->overlimit
> for every packet the eviction loop drops, and fq->overmemory only for the
> subset dropped because the memory limit was exceeded, so overmemory is
> always the smaller of the two. Reading the file to tell which limit is
> binding gives the opposite answer.
>
> Fixes: 2a4e675d887b ("mac80211: Export fq memory limit information in debugfs")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Julius Bairaktaris <julius@bairaktaris.de>

Reviewed-by: Toke Høiland-Jørgensen <toke@toke.dk>

  reply	other threads:[~2026-08-24 10:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 19:57 [PATCH v1] wifi: mac80211: fix swapped fq_overlimit/fq_overmemory in aqm debugfs Julius Bairaktaris
2026-08-24 10:44 ` Toke Høiland-Jørgensen [this message]
2026-09-04  7:51 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0dver10.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=johannes@sipsolutions.net \
    --cc=julius@bairaktaris.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.