Re: [PATCH] sandbox/seunshare: fix error checking for setfsuid()

[Petr Lautrbach <plautrba@redhat.com>]

Stephen Smalley <stephen.smalley.work@gmail.com> writes:

> setfsuid() doesn't reliably set errno or return anything indicating
> an error.
>
> Signed-off-by: Stephen Smalley <stephen.smalley.work@gmail.com>

Acked-by: Petr Lautrbach <lautrbach@redhat.com>

> ---
>  sandbox/seunshare.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sandbox/seunshare.c b/sandbox/seunshare.c
> index 17a727e7..b9c85bf2 100644
> --- a/sandbox/seunshare.c
> +++ b/sandbox/seunshare.c
> @@ -858,8 +858,8 @@ int main(int argc, char **argv) {
>  	/* Changing fsuid is usually required when user-specified directory is
>  	 * on an NFS mount.  It's also desired to avoid leaking info about
>  	 * existence of the files not accessible to the user. */
> -	if (((uid_t)setfsuid(uid) != 0)   && (errno != 0)) {
> -		fprintf(stderr, _("Error: unable to setfsuid %m\n"));
> +	if ((uid_t)setfsuid(uid) != 0) {
> +		fprintf(stderr, _("Error: unable to setfsuid\n"));
>  
>  		return -1;
>  	}
> -- 
> 2.54.0