All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Jaehoon Kim <jhkim@linux.ibm.com>,
	qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: richard.henderson@linaro.org, iii@linux.ibm.com,
	david@kernel.org, pasic@linux.ibm.com, borntraeger@linux.ibm.com,
	farman@linux.ibm.com, mjrosato@linux.ibm.com,
	Jaehoon Kim <jhkim@linux.ibm.com>,
	Mohamed Mediouni <mohamed@unpredictable.fr>
Subject: Re: [PATCH v2 1/1] hw/s390x/ccw: Disable legacy virtio-pci by default (v11.1+)
Date: Wed, 22 Apr 2026 11:53:34 +0200	[thread overview]
Message-ID: <87y0ifs4m9.fsf@redhat.com> (raw)
In-Reply-To: <20260420144759.2970726-2-jhkim@linux.ibm.com>

On Mon, Apr 20 2026, Jaehoon Kim <jhkim@linux.ibm.com> wrote:

> On the s390 Linux kernel, IO_SPACE_LIMIT has been 0 since the initial
> zPCI implementation (commit cd24834130ac "s390/pci: base support"),
> making I/O BARs unusable.
>
> However, when virtio-pci devices operate in transitional mode, QEMU
> unconditionally exposes the legacy interface via BAR0. This results in
> firmware warnings during PCI enumeration, such as:
>
>   pci 0005:00:00.0: [Firmware Bug]: BAR 0: invalid; can't size
>
> even though BAR0 is never usable on the s390 kernel.
>
> Close this gap by disabling legacy virtio-pci support starting from
> machine version 11.1. This effectively makes virtio-pci devices
> non-transitional and prevents the creation of the unusable legacy I/O
> BAR.
>
> This introduces s390x-specific global compatibility properties that
> set disable-legacy=on as the default for virtio-pci devices. Machine
> versions v11.0 and earlier set disable-legacy=off to maintain their
> original default behavior (legacy support enabled), ensuring VMs
> created with those versions continue to work identically.
>
> Users can override the default on the command line if needed:
>   - On v11.1+: -global virtio-pci.disable-legacy=off (to enable legacy)
>   - On v11.0-: -global virtio-pci.disable-legacy=on (to disable legacy)
>
> Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com>
> Reviewed-by: Mohamed Mediouni <mohamed@unpredictable.fr>
> ---
>  hw/s390x/s390-virtio-ccw.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Thanks, queued to s390-next.



      parent reply	other threads:[~2026-04-22  9:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 14:47 [PATCH v2 0/1] hw/s390x/ccw: Disable legacy mode Jaehoon Kim
2026-04-20 14:47 ` [PATCH v2 1/1] hw/s390x/ccw: Disable legacy virtio-pci by default (v11.1+) Jaehoon Kim
2026-04-21 18:01   ` Matthew Rosato
2026-04-21 22:34   ` Halil Pasic
2026-04-22  9:53   ` Cornelia Huck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0ifs4m9.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=jhkim@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=mohamed@unpredictable.fr \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.