Re: [PATCH] ALSA: usb-audio: qcom: Fix incorrect type in enable_audio_stream

[Takashi Iwai <tiwai@suse.de>]

On Wed, 08 Apr 2026 07:43:04 +0200,
songxiebing wrote:
> 
> Fix sparse warning:
> sound/usb/qcom/qc_audio_offload.c:943:27: sparse: incorrect type in argument 2
> expected unsigned int val but got snd_pcm_format_t.
> 
> Explicitly cast pcm_format to unsigned int for snd_mask_leave().
> 
> Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604062109.Oxi8JjWW-lkp@intel.com/
> Signed-off-by: songxiebing <songxiebing@kylinos.cn>
> ---
>  sound/usb/qcom/qc_audio_offload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
> index f161eb29f911..423e4a9b62e2 100644
> --- a/sound/usb/qcom/qc_audio_offload.c
> +++ b/sound/usb/qcom/qc_audio_offload.c
> @@ -947,7 +947,7 @@ static int enable_audio_stream(struct snd_usb_substream *subs,
>  	_snd_pcm_hw_params_any(&params);
>  
>  	m = hw_param_mask(&params, SNDRV_PCM_HW_PARAM_FORMAT);
> -	snd_mask_leave(m, pcm_format);
> +	snd_mask_leave(m, (unsigned int)pcm_format);

I believe you need __force prefix for cast, as it's strong-typed.


thanks,

Takashi