From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70ABCEF48ED for ; Fri, 13 Feb 2026 09:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qExmFidqS659wTeV1ENqfkz2qDtwKx1pH96OXaAsz64=; b=ec3Ifao5Hhc4SR FmF3V8w61pvEvtIOO4VoyMRNein5vK/OFgLQsFyrt+L9L9Ltf+g7glm0EYz+bPxYqyBhO/gKKXgtK LQO7/P5wkwtZLDn/+hZH//5lUVhCRA6LADexAJTuVrZh4xWNtLUH/b0RmcybvNcqzzPXGcZxIrHoq OsFR2BZRyQDZJIT8Y7SbWHSuw9BySxivLmifcWS35C4fc0M8DCxhwBupf17vQH6B5tRoRaalJA/LN QARzAH/ZyDboMpshPnEihow/FztM10/X+z43BhZclQplXLoMvXJvoVfy4VMY4845d+9lfAgMY77Ga Gysu9kCX14/DUGkEtJJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqp3X-00000003CtQ-1sIL; Fri, 13 Feb 2026 09:01:43 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqp3V-00000003CsI-0C92 for linux-mtd@lists.infradead.org; Fri, 13 Feb 2026 09:01:43 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 5A915C1E4A2; Fri, 13 Feb 2026 09:01:44 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C2E35606CC; Fri, 13 Feb 2026 09:01:34 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8D05910368D90; Fri, 13 Feb 2026 10:01:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770973292; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=rp1eDOIRhaqWCkYz+NWbK33lJyO3gCS1N2c/2rJWg/E=; b=ajnFwvybN/0XFrBUedxR74LHa2roePtEFDzO102eE0A34vTv8r/teN6VmAyqa5UaQ3PAS5 nCSZFLxbHzsN0+Gwxsk0vV/Fc7Gp3KOXPPhgR8ATlUbvlAkNk1BRb9AFPJHWbKennAVtes zWj8QxYJpIFfqHx5V6o8iIA62QSD5hwxd8lacmpYG2mNdSFsf5m+bhEUXxzM205MJYcIQ2 4Ac7speu6a2fbuuV1FGAoHu7eNwrOYxfnMXTCrKA9B6ng3mv46LV7UmvhFkMzbz4GyiELR hOn/psaAkqctQA8IQUKxZTjiRERWxnwFnwZh9sKNQ0ft1qzBvDK/fVTVembZKA== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 00/12] spi: cadence-quadspi: add PHY tuning support In-Reply-To: <775d8dce-b567-4f21-963c-a843e409fea5@ti.com> (Santhosh Kumar K.'s message of "Sat, 7 Feb 2026 00:58:03 +0530") References: <20260113141617.1905039-1-s-k6@ti.com> <87343ghkek.fsf@bootlin.com> <87v7gbdwdh.fsf@bootlin.com> <775d8dce-b567-4f21-963c-a843e409fea5@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 13 Feb 2026 10:01:28 +0100 Message-ID: <87y0kxvwyf.fsf@bootlin.com> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260213_010141_229983_AC4A6CB0 X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMDcvMDIvMjAyNiBhdCAwMDo1ODowMyArMDUzMCwgU2FudGhvc2ggS3VtYXIgSyA8cy1rNkB0 aS5jb20+IHdyb3RlOgoKPiBPbiAwNS8wMi8yNiAyMToxOCwgTWlxdWVsIFJheW5hbCB3cm90ZToK Pj4gSGkgU2FudGhvc2gsCj4+IAo+Pj4gSSBhbSBzdXJwcmlzZWQgYnkgdGhlc2UgbnVtYmVycywg SSB3b3VsZCBleHBlY3QgdGhlc2UgdG8gZ2V0IGhpZ2hlciBmb3IKPj4+IFNQSSBOQU5Ecy4gSSB3 aWxsIHRlc3QgdGhlIHNlcmllcyBhbmQgcmVwb3J0IG15IG9ic2VydmF0aW9ucywgZXNwZWNpYWxs eQo+Pj4gc2luY2UgdGhlcmUgaXMgYWxzbyBPRERSIFNQSSBOQU5EIHN1cHBvcnQgbm93IChpbiBu YW5kL25leHQsIHNob3VsZCBiZQo+Pj4gcGFydCBvZiBteSB1cGNvbWluZyBtZXJnZSByZXF1ZXN0 IHRvIExpbnVzIGZvciA2LjE5KzEpOwo+PiBJIGp1c3QgdGVzdGVkIHRoZSBzZXJpZXMsIGhlcmUg YXJlIHNvbWUgbnVtYmVycyBJIGdyYWJiZWQgb24gVEkgQU02MkE3Cj4+IExQIFNLIHdpdGggYSBX aW5ib25kIFczNU4wMiBTUEkgTkFORCBjaGlwIChzbyBpbiB0aGUgZW5kIHZlcnkgY2xvc2UgdG8K Pj4geW91ciByZXBvcnQpOgo+PiAgICstLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLSstLS0t LS0tLS0tLS0rCj4+ICAgfCBTUEkgTkFORCAgICAgICAgfCBubyB0dW5pbmcgfCBQSFkgdHVuaW5n IHwKPj4gICB8IFVuaXQ6IE1pQi9zICAgICB8ICAgMjVNSHogICB8ICAgMTY2TUh6ICAgfAo+PiAg IHwtLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLSstLS0tLS0tLS0tLS18Cj4+ICAgfCBPY3Rh bCBTRFIgcmVhZCAgfCAgIDEzLjggICAgfCAgICAzNC4yICAgIHwKPj4gICB8ICAgICAgICAgICB3 cml0ZSB8ICAgIDcuMiAgICB8ICAgIDEwLjIgICAgfAo+PiAgIHwtLS0tLS0tLS0tLS0tLS0tLSst LS0tLS0tLS0tLSstLS0tLS0tLS0tLS18Cj4+ICAgfCBPY3RhbCBEVFIgcmVhZCAgfCAgIDIxLjIg ICAgfCAgICAgTi9BICAgIHwKPj4gICB8ICAgICAgICAgICB3cml0ZSB8ICAgIDkuMCAgICB8ICAg ICBOL0EgICAgfAo+PiAgICstLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLSstLS0tLS0tLS0t LS0rCj4+IFBsZWFzZSBtaW5kIEkgdXNlZCBNaUIvcyBhbmQgbm90IE1CL3MgKHNvIGtpQiAvIDEw MjQpLCBJIGRvbid0IGtub3cKPj4gd2hpY2ggb25lIHlvdSB1c2VkIGZvciBtZWFzdXJpbmcsIGFz IHlvdSBtYXJrZWQgTUIsIHdoZXJlYXMgdGhlIG1vc3QKPj4gY29tbW9uIHVuaXQgc2VlbXMgdG8g YmUgTWlCLgo+PiBIb3dldmVyIFBIWSB0dW5pbmcgZmFpbGVkIGluIE9jdGFsIERUUiBtb2RlICh5 b3VyIHNlcmllcyBhcHBsaWVkIG9uCj4+IHRvcAo+PiBvZiBuYW5kL25leHQpIHdpdGggdGhlIGZv bGxvd2luZyBsb2dzLCBjYW4geW91IGhhdmUgYSBsb29rPwo+PiBbICAgIDIuMjYxNjQ3XSBzcGkt bmFuZCBzcGkwLjA6IFdpbmJvbmQgU1BJIE5BTkQgd2FzIGZvdW5kLgo+PiBbICAgIDIuMjY2OTU2 XSBzcGktbmFuZCBzcGkwLjA6IDEyOCBNaUIsIGJsb2NrIHNpemU6IDI1NiBLaUIsIHBhZ2Ugc2l6 ZTogNDA5NiwgT09CIHNpemU6IDEyOAo+PiBbICAgIDIuMjg1MjU3XSBjYWRlbmNlLXFzcGkgZmM0 MDAwMC5zcGk6IFBIWSB0dW5pbmcgZmFpbGVkOiAtMgo+PiBbICAgIDIuMjkwODM1XSBzcGktbmFu ZCBzcGkwLjA6IEZhaWxlZCB0byBleGVjdXRlIFBIWSB0dW5pbmc6IC0yCj4KPiBVbmZvcnR1bmF0 ZWx5LCBkdWUgdG8gYSBrbm93biBlcnJhdHVtIGluIHRoZSBDYWRlbmNlIGNvbnRyb2xsZXIsIFBI WSBERFIKPiBtb2RlIGNhbm5vdCBiZSB1c2VkIHdpdGggMi1ieXRlIGFkZHJlc3NpbmcuCj4KPiBS ZWZlcjoKPiBFcnJhdGEgaTIzODM6IE9TUEk6IDItYnl0ZSBhZGRyZXNzIGlzIG5vdCBzdXBwb3J0 ZWQgaW4gUEhZIEREUiBtb2RlIFsxXQo+Cj4gQXMgYSByZXN1bHQsIHRoZSBDYWRlbmNlIGNvbnRy b2xsZXIgc3VwcG9ydHMgb25seSB0aGUgZm9sbG93aW5nCj4gb3BlcmF0aW5nIG1vZGVzOgo+ICAt IFBIWSBERFIgbW9kZSB3aXRoIDQtYnl0ZSBhZGRyZXNzaW5nCj4gIC0gUEhZIFNEUiBtb2RlCj4g IC0gVEFQIChub24tUEhZKSBERFIgbW9kZQo+ICAtIFRBUCAobm9uLVBIWSkgU0RSIG1vZGUKCkkg ZG8gbm90IHRoaW5rIHdlIGhhdmUgNC1ieXRlIGFkZHJlc3NpbmcgY2FwYWJpbGl0aWVzIG9uIFNQ SSBOQU5EIGNoaXBzLAplc3AuIFdpbmJvbmQncyBjaGlwcy4gU28gdGhlcmUgaXMgYSBkb3duIHNp ZGU6IHRoZSBjb3JlIHdpbGwgcGljay11cApPY3RhbCBEVFIgbW9kZXMgcmF0aGVyIHRoYW4gT2N0 YWwgU0RSICh3aXRoIFBIWSkgbW9kZSwgd2hpY2ggaXMgbm90IHRoZQpmYXN0ZXN0IG1vZGUuIE1h eWJlIHdlIGNhbiBndWVzcyB0aGF0IG9uY2Ugd2UgaGF2ZSBhY2Nlc3MgdG8gdGhlIG1heAoodHVu ZWQgUEhZKSBzcGkgZnJlcXVlbmN5LCB3aXRoIGFuIGV4dHJhIGZsYWcgaW4gdGhlIGRyaXZlciBp bmRpY2F0aW5nCnRoYXQgdGhlIFBIWSBzcGVlZCBpcyBub3QgYWNjZXNzaWJsZSBpbiBEVFIgbW9k ZS4gQnV0IHRoaXMgYWdhaW4KcmVxdWlyZXMgZGlmZmVyZW50IGhhbmRsaW5nIGJldHdlZW4gU1BJ IE5BTkQgYW5kIFNQSSBOT1IsIGFzIFNQSSBOT1IKSUlSQyBtYXkgaGF2ZSA0LWJ5dGUgYWRkcmVz c2luZyBjYXBhYmlsaXRpZXMuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBt YWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 846662609FD for ; Fri, 13 Feb 2026 09:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770973298; cv=none; b=tjhQIryoEczO2Bfk2KqC8garpoA7XUattf8CLFcNy0DwIb9u/0k+2zYgTZOSrXM0J47lVi1N/pReBYXLbZtVFXW9JtCwdhzq0zV19RzNTeZvv4+3rKuE5Acrq0db1YsA4LfraWKSUJtLnKy0pFe0qi5MaNRBZLIWwf0voKc6BvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770973298; c=relaxed/simple; bh=jNO73u+i65xkf0YweV1puplp8BRnzGz5roCr1o00jwY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=EdU3M5Dn9y4kP4OtFz9Yx9+IjbBjxseXCFwuWxGxtFUPPBszki8q9gw7hfUoslu3f+sBHd+VlyHXL/FbW7+MoAoMhAEkbzFbmkoZXxd9zIIVqrw16pY55LOlVEQ0bFsUGi2ifuP9IEncypkzEkk5r0eytkLKqCXYnHklPaqBjLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ajnFwvyb; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ajnFwvyb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id F1B794E40D27; Fri, 13 Feb 2026 09:01:34 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C2E35606CC; Fri, 13 Feb 2026 09:01:34 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8D05910368D90; Fri, 13 Feb 2026 10:01:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770973292; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=rp1eDOIRhaqWCkYz+NWbK33lJyO3gCS1N2c/2rJWg/E=; b=ajnFwvybN/0XFrBUedxR74LHa2roePtEFDzO102eE0A34vTv8r/teN6VmAyqa5UaQ3PAS5 nCSZFLxbHzsN0+Gwxsk0vV/Fc7Gp3KOXPPhgR8ATlUbvlAkNk1BRb9AFPJHWbKennAVtes zWj8QxYJpIFfqHx5V6o8iIA62QSD5hwxd8lacmpYG2mNdSFsf5m+bhEUXxzM205MJYcIQ2 4Ac7speu6a2fbuuV1FGAoHu7eNwrOYxfnMXTCrKA9B6ng3mv46LV7UmvhFkMzbz4GyiELR hOn/psaAkqctQA8IQUKxZTjiRERWxnwFnwZh9sKNQ0ft1qzBvDK/fVTVembZKA== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 00/12] spi: cadence-quadspi: add PHY tuning support In-Reply-To: <775d8dce-b567-4f21-963c-a843e409fea5@ti.com> (Santhosh Kumar K.'s message of "Sat, 7 Feb 2026 00:58:03 +0530") References: <20260113141617.1905039-1-s-k6@ti.com> <87343ghkek.fsf@bootlin.com> <87v7gbdwdh.fsf@bootlin.com> <775d8dce-b567-4f21-963c-a843e409fea5@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 13 Feb 2026 10:01:28 +0100 Message-ID: <87y0kxvwyf.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 07/02/2026 at 00:58:03 +0530, Santhosh Kumar K wrote: > On 05/02/26 21:18, Miquel Raynal wrote: >> Hi Santhosh, >>=20 >>> I am surprised by these numbers, I would expect these to get higher for >>> SPI NANDs. I will test the series and report my observations, especially >>> since there is also ODDR SPI NAND support now (in nand/next, should be >>> part of my upcoming merge request to Linus for 6.19+1); >> I just tested the series, here are some numbers I grabbed on TI AM62A7 >> LP SK with a Winbond W35N02 SPI NAND chip (so in the end very close to >> your report): >> +-----------------+-----------+------------+ >> | SPI NAND | no tuning | PHY tuning | >> | Unit: MiB/s | 25MHz | 166MHz | >> |-----------------+-----------+------------| >> | Octal SDR read | 13.8 | 34.2 | >> | write | 7.2 | 10.2 | >> |-----------------+-----------+------------| >> | Octal DTR read | 21.2 | N/A | >> | write | 9.0 | N/A | >> +-----------------+-----------+------------+ >> Please mind I used MiB/s and not MB/s (so kiB / 1024), I don't know >> which one you used for measuring, as you marked MB, whereas the most >> common unit seems to be MiB. >> However PHY tuning failed in Octal DTR mode (your series applied on >> top >> of nand/next) with the following logs, can you have a look? >> [ 2.261647] spi-nand spi0.0: Winbond SPI NAND was found. >> [ 2.266956] spi-nand spi0.0: 128 MiB, block size: 256 KiB, page size:= 4096, OOB size: 128 >> [ 2.285257] cadence-qspi fc40000.spi: PHY tuning failed: -2 >> [ 2.290835] spi-nand spi0.0: Failed to execute PHY tuning: -2 > > Unfortunately, due to a known erratum in the Cadence controller, PHY DDR > mode cannot be used with 2-byte addressing. > > Refer: > Errata i2383: OSPI: 2-byte address is not supported in PHY DDR mode [1] > > As a result, the Cadence controller supports only the following > operating modes: > - PHY DDR mode with 4-byte addressing > - PHY SDR mode > - TAP (non-PHY) DDR mode > - TAP (non-PHY) SDR mode I do not think we have 4-byte addressing capabilities on SPI NAND chips, esp. Winbond's chips. So there is a down side: the core will pick-up Octal DTR modes rather than Octal SDR (with PHY) mode, which is not the fastest mode. Maybe we can guess that once we have access to the max (tuned PHY) spi frequency, with an extra flag in the driver indicating that the PHY speed is not accessible in DTR mode. But this again requires different handling between SPI NAND and SPI NOR, as SPI NOR IIRC may have 4-byte addressing capabilities. Thanks, Miqu=C3=A8l