From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CC60D74ED9 for ; Fri, 23 Jan 2026 14:12:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjHt3-0003tE-K3; Fri, 23 Jan 2026 09:11:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjHsu-0003K1-SL for qemu-devel@nongnu.org; Fri, 23 Jan 2026 09:11:38 -0500 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vjHsr-0002vD-Nj for qemu-devel@nongnu.org; Fri, 23 Jan 2026 09:11:35 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 75B343380B; Fri, 23 Jan 2026 14:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769177492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wRjuR6dBGe2mCvwr3FYvXl8jyqwLJv9qM07O7L9lw+c=; b=G94p9yw15RVZcuTexBB4wPRKoOsB0GxfGTtQ89Nyxmjbpa33zIKCytZM9E/vCzkhUctyZw +GVMkSWh45/FgYNJtiIjCDD8NwQJpVb0fj14k2W6e2DnWnSkExoLVLZwUmS+CKwo0UCea6 fUP4hyL0NwYsLkN9+sYL0sOdqAuapVg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769177492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wRjuR6dBGe2mCvwr3FYvXl8jyqwLJv9qM07O7L9lw+c=; b=fE/V90KCQHakD9CCMoxciMr9sQtmBTqb5EsnDMqdzIo2Fv408SbwpcXofFG5HWLihsAhC5 cVNkewRtYHe+WtCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=G94p9yw1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="fE/V90KC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769177492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wRjuR6dBGe2mCvwr3FYvXl8jyqwLJv9qM07O7L9lw+c=; b=G94p9yw15RVZcuTexBB4wPRKoOsB0GxfGTtQ89Nyxmjbpa33zIKCytZM9E/vCzkhUctyZw +GVMkSWh45/FgYNJtiIjCDD8NwQJpVb0fj14k2W6e2DnWnSkExoLVLZwUmS+CKwo0UCea6 fUP4hyL0NwYsLkN9+sYL0sOdqAuapVg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769177492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wRjuR6dBGe2mCvwr3FYvXl8jyqwLJv9qM07O7L9lw+c=; b=fE/V90KCQHakD9CCMoxciMr9sQtmBTqb5EsnDMqdzIo2Fv408SbwpcXofFG5HWLihsAhC5 cVNkewRtYHe+WtCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E6CF91395E; Fri, 23 Jan 2026 14:11:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ya+FKJOBc2khFwAAD6G6ig (envelope-from ); Fri, 23 Jan 2026 14:11:31 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: Prasad Pandit , Lukas Straub , Juraj Marcin , peterx@redhat.com Subject: Re: [PATCH 10/10] migration: Drop iterable_only in qemu_savevm_state_complete_precopy In-Reply-To: <20260121223336.3381912-11-peterx@redhat.com> References: <20260121223336.3381912-1-peterx@redhat.com> <20260121223336.3381912-11-peterx@redhat.com> Date: Fri, 23 Jan 2026 11:11:29 -0300 Message-ID: <87y0loh10u.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[web.de]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[redhat.com,web.de]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 75B343380B X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > Now after removing the special case in COLO, we can drop this parameter. > > Signed-off-by: Peter Xu > --- > migration/savevm.h | 2 +- > migration/migration.c | 2 +- > migration/savevm.c | 12 +++++------- > 3 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/migration/savevm.h b/migration/savevm.h > index 528607f09e..ea01ca63ec 100644 > --- a/migration/savevm.h > +++ b/migration/savevm.h > @@ -42,7 +42,7 @@ void qemu_savevm_state_header(QEMUFile *f); > int qemu_savevm_state_iterate(QEMUFile *f, bool postcopy); > void qemu_savevm_state_cleanup(void); > void qemu_savevm_state_complete_postcopy(QEMUFile *f); > -int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only); > +int qemu_savevm_state_complete_precopy(QEMUFile *f); > void qemu_savevm_state_pending_exact(uint64_t *must_precopy, > uint64_t *can_postcopy); > void qemu_savevm_state_pending_estimate(uint64_t *must_precopy, > diff --git a/migration/migration.c b/migration/migration.c > index 1bcde301f7..5d21d6dc11 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -3018,7 +3018,7 @@ static int migration_completion_precopy(MigrationState *s) > goto out_unlock; > } > > - ret = qemu_savevm_state_complete_precopy(s->to_dst_file, false); > + ret = qemu_savevm_state_complete_precopy(s->to_dst_file); > out_unlock: > bql_unlock(); > return ret; > diff --git a/migration/savevm.c b/migration/savevm.c > index 529cf310e0..1bf1037ce1 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -1717,7 +1717,7 @@ int qemu_savevm_state_complete_precopy_non_iterable(QEMUFile *f, > return 0; > } > > -int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only) > +int qemu_savevm_state_complete_precopy(QEMUFile *f) > { > int ret; > > @@ -1726,11 +1726,9 @@ int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only) > return ret; > } > > - if (!iterable_only) { > - ret = qemu_savevm_state_complete_precopy_non_iterable(f, false); > - if (ret) { > - return ret; > - } > + ret = qemu_savevm_state_complete_precopy_non_iterable(f, false); > + if (ret) { > + return ret; > } > > return qemu_fflush(f); > @@ -1831,7 +1829,7 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp) > ret = qemu_file_get_error(f); > if (ret == 0) { > qemu_savevm_maybe_send_switchover_start(f); > - qemu_savevm_state_complete_precopy(f, false); > + qemu_savevm_state_complete_precopy(f); > ret = qemu_file_get_error(f); > } > if (ret != 0) { Reviewed-by: Fabiano Rosas