All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Kaustabh Chakraborty <kauschluss@disroot.org>, u-boot@lists.denx.de
Cc: Sam Protsenko <semen.protsenko@linaro.org>,
	Tom Rini <trini@konsulko.com>, Minkyu Kang <mk7.kang@samsung.com>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Kaustabh Chakraborty <kauschluss@disroot.org>
Subject: Re: [PATCH RESEND 1/2] phy: samsung: add enum for variants based on SoCs
Date: Fri, 16 Jan 2026 13:44:12 +0100	[thread overview]
Message-ID: <87y0lxd8wz.fsf@kernel.org> (raw)
In-Reply-To: <20260103-phy-usb-exynos7870-v1-1-08f3e9814b86@disroot.org>

Hi Kaustabh,

Thank you for the patch.

On Sat, Jan 03, 2026 at 18:22, Kaustabh Chakraborty <kauschluss@disroot.org> wrote:

> The variant enum is used to uniquely identify which SoC the PHY block
> belongs to. It is initially set in the match table, along with the
> compatible string, it gets copied to driver data struct during probe.
>
> SoC specific functions must only be called if the respective variant
> enum is set. Add switch-case blocks wherever required.
>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  drivers/phy/phy-exynos-usbdrd.c | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos-usbdrd.c b/drivers/phy/phy-exynos-usbdrd.c
> index db5815ed184..4ab8da2a08f 100644
> --- a/drivers/phy/phy-exynos-usbdrd.c
> +++ b/drivers/phy/phy-exynos-usbdrd.c
> @@ -66,6 +66,10 @@
>  #define KHZ					1000
>  #define MHZ					(KHZ * KHZ)

  reply	other threads:[~2026-01-16 12:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-03 12:52 [PATCH RESEND 0/2] Support for Samsung Exynos 7870 USB PHY device in driver Kaustabh Chakraborty
2026-01-03 12:52 ` [PATCH RESEND 1/2] phy: samsung: add enum for variants based on SoCs Kaustabh Chakraborty
2026-01-16 12:44   ` Mattijs Korpershoek [this message]
2026-01-03 12:52 ` [PATCH RESEND 2/2] phy: samsung: add support for exynos7870 USB PHY Kaustabh Chakraborty
2026-01-16 13:06   ` Mattijs Korpershoek
2026-02-01  9:51 ` [PATCH RESEND 0/2] Support for Samsung Exynos 7870 USB PHY device in driver Kaustabh Chakraborty
2026-02-02  7:57   ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0lxd8wz.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=kauschluss@disroot.org \
    --cc=mk7.kang@samsung.com \
    --cc=semen.protsenko@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.