All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org,
	 Richard Henderson <richard.henderson@linaro.org>,
	 Helge Deller <deller@gmx.de>
Subject: Re: [PATCH 0/2] hw/pci-host: fix use-after-free in hppa pci-host devices
Date: Mon, 22 Sep 2025 10:03:47 +0100	[thread overview]
Message-ID: <87y0q6q2oc.fsf@draig.linaro.org> (raw)
In-Reply-To: <20250918114259.1802337-1-peter.maydell@linaro.org> (Peter Maydell's message of "Thu, 18 Sep 2025 12:42:57 +0100")

Peter Maydell <peter.maydell@linaro.org> writes:

> This patchset fixes use-after-free bugs which show up if you put
> some of the hppa pci-host devices through an "init -> deinit" lifecycle,
> as the device-introspect-test does.
>
> The problem in both cases is that we were calling pci_register_root_bus()
> in instance_init: we should only call this in realize, as all the
> other callers do.
>
> These bugs show up if you run 'make check' with an ASAN enabled
> build; they are also likely behind the intermittent segfaults
> on s390 that RTH has noticed recently.

Tested-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  parent reply	other threads:[~2025-09-22  9:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 11:42 [PATCH 0/2] hw/pci-host: fix use-after-free in hppa pci-host devices Peter Maydell
2025-09-18 11:42 ` [PATCH 1/2] hw/pci-host/dino: Don't call pci_register_root_bus() in init Peter Maydell
2025-09-22  9:18   ` Alex Bennée
2025-09-18 11:42 ` [PATCH 2/2] hw/pci-host/astro: Don't call pci_regsiter_root_bus() " Peter Maydell
2025-09-18 11:59   ` Peter Maydell
2025-09-22  9:18   ` Alex Bennée
2025-09-22  9:03 ` Alex Bennée [this message]
2025-09-23 23:53 ` [PATCH 0/2] hw/pci-host: fix use-after-free in hppa pci-host devices Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0q6q2oc.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=deller@gmx.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.