[PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation

[PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation

[Zenghui Yu]

An ITS cache invalidation has been performed immediately after programming
the L2 DTE in gicv5_its_device_register(). No need to perform it again
right after a successful gicv5_its_device_register().

Remove it.

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 drivers/irqchip/irq-gic-v5-its.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
index 2fb58d76f521..554485f0be1f 100644
--- a/drivers/irqchip/irq-gic-v5-its.c
+++ b/drivers/irqchip/irq-gic-v5-its.c
@@ -768,8 +768,6 @@ static struct gicv5_its_dev *gicv5_its_alloc_device(struct gicv5_its_chip_data *
 		goto out_dev_free;
 	}
 
-	gicv5_its_device_cache_inv(its, its_dev);
-
 	its_dev->its_node = its;
 
 	its_dev->event_map = (unsigned long *)bitmap_zalloc(its_dev->num_events, GFP_KERNEL);
-- 
2.33.0

Re: [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation

[Marc Zyngier]

On Wed, 03 Sep 2025 03:33:19 +0100,
Zenghui Yu <yuzenghui@huawei.com> wrote:
> 
> An ITS cache invalidation has been performed immediately after programming
> the L2 DTE in gicv5_its_device_register(). No need to perform it again
> right after a successful gicv5_its_device_register().

Indeed. And this call doesn't check it's been successful either.

> 
> Remove it.
> 
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
>  drivers/irqchip/irq-gic-v5-its.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index 2fb58d76f521..554485f0be1f 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -768,8 +768,6 @@ static struct gicv5_its_dev *gicv5_its_alloc_device(struct gicv5_its_chip_data *
>  		goto out_dev_free;
>  	}
>  
> -	gicv5_its_device_cache_inv(its, its_dev);
> -
>  	its_dev->its_node = its;
>  
>  	its_dev->event_map = (unsigned long *)bitmap_zalloc(its_dev->num_events, GFP_KERNEL);

Reviewed-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Jazz isn't dead. It just smells funny.

[tip: irq/drivers] irqchip/gic-v5: Remove the redundant ITS cache invalidation

[tip-bot2 for Zenghui Yu]

The following commit has been merged into the irq/drivers branch of tip:

Commit-ID:     54a1726d2e4c0c7b33f4e5ef35fcc118a4d74ea3
Gitweb:        https://git.kernel.org/tip/54a1726d2e4c0c7b33f4e5ef35fcc118a4d74ea3
Author:        Zenghui Yu <yuzenghui@huawei.com>
AuthorDate:    Wed, 03 Sep 2025 10:33:19 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 03 Sep 2025 14:09:01 +02:00

irqchip/gic-v5: Remove the redundant ITS cache invalidation

An ITS cache invalidation has been performed immediately after programming
the L2 DTE in gicv5_its_device_register(). No need to perform it again
right after a successful gicv5_its_device_register().

Remove it.

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/all/20250903023319.1820-1-yuzenghui@huawei.com

---
 drivers/irqchip/irq-gic-v5-its.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
index 9290ac7..81d813c 100644
--- a/drivers/irqchip/irq-gic-v5-its.c
+++ b/drivers/irqchip/irq-gic-v5-its.c
@@ -768,8 +768,6 @@ static struct gicv5_its_dev *gicv5_its_alloc_device(struct gicv5_its_chip_data *
 		goto out_dev_free;
 	}
 
-	gicv5_its_device_cache_inv(its, its_dev);
-
 	its_dev->its_node = its;
 
 	its_dev->event_map = (unsigned long *)bitmap_zalloc(its_dev->num_events, GFP_KERNEL);