From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB51914658D for ; Wed, 13 Aug 2025 01:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755049604; cv=none; b=hgBTZ7g4YZ3qXiFj5P1DIgZe8JeecvUs+QduxMDQMYhc8YDzrJMqrTMTTeHEkwbNKV2ghNyiDqemNf1AKLUkdzOmMiNHF8lgu2NnACiiF/0641w34+un/s+VGw4MJndBHEPL03dz35TluoIBjRp0W23rFOFMF/nklyDnOWgiLtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755049604; c=relaxed/simple; bh=8cimGdearmvYVQCy5FWmG8x9rA0b5/NI1ufddvwaDAw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=DE7u65TeOtDGkNs4kn27wGJprhtX/UvjaoYVAxZtbe44zoptkP3kELzXfMekwce+NGWpYRN4UFKw2U4oRatDVD9oITYZ5/ZaCyrzY7NwfNGOudwyIB7ZrLWbWDm+dyhobFNogMjZ5TUyMt/jHCPABmT7Xa2CwmQf4t3oBDAxirI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=evfVPnTg; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="evfVPnTg" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755049599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8cimGdearmvYVQCy5FWmG8x9rA0b5/NI1ufddvwaDAw=; b=evfVPnTgHBhA7AgQGRCHcwiqrgOLYAmg6DPpQQtrxVPp8a6y8pvPbiBeqN3gS8rxKUoiLV TCqpB+VncP3f1jKieCNBCXbddW8YQuRWO/bJfrbxAr50x0SFMoB9a8FCZZSnKP+UM+hKI+ Jyy1cHE3qlMr1nyxI89fKAUrUQM6YGE= From: Roman Gushchin To: Kuniyuki Iwashima Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Neal Cardwell , Paolo Abeni , Willem de Bruijn , Matthieu Baerts , Mat Martineau , Johannes Weiner , Michal Hocko , Shakeel Butt , Andrew Morton , =?utf-8?Q?Michal_Koutn=C3=BD?= , Tejun Heo , Simon Horman , Geliang Tang , Muchun Song , Mina Almasry , Kuniyuki Iwashima , netdev@vger.kernel.org, mptcp@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 net-next 07/12] net-memcg: Introduce mem_cgroup_sk_enabled(). In-Reply-To: <20250812175848.512446-8-kuniyu@google.com> (Kuniyuki Iwashima's message of "Tue, 12 Aug 2025 17:58:25 +0000") References: <20250812175848.512446-1-kuniyu@google.com> <20250812175848.512446-8-kuniyu@google.com> Date: Tue, 12 Aug 2025 18:46:29 -0700 Message-ID: <87y0roq9hm.fsf@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT Kuniyuki Iwashima writes: > The socket memcg feature is enabled by a static key and > only works for non-root cgroup. > > We check both conditions in many places. > > Let's factorise it as a helper function. > > Signed-off-by: Kuniyuki Iwashima > Reviewed-by: Eric Dumazet Acked-by: Roman Gushchin