From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F094CC3ABC9 for ; Fri, 9 May 2025 10:08:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93BE210E9F4; Fri, 9 May 2025 10:08:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="YfGsHwZL"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7053610E9F1; Fri, 9 May 2025 10:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746785327; x=1778321327; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=yN2RUVVi8fYPQ0/asHBvQmRdd5FpMKMJ5POOGc3x3Zs=; b=YfGsHwZLxMtHQ+MY6dvQkEj3A9lDt78iYwXkVd+eTa6sdaZ4EOagKd+X bnwY37uJuk/4jaHDPjBwBH7Z1SY+YNzjJHB23kN5UvovCTF/ZC5XXe/hC CWRFY/aPkZF/pxwkd9FXVCA1hgMZ/d+tj++riubQAMGVmkIdKsUHDruiZ SvZvWM2xIRJMFNHzLiyVkYUt8j4IPYxbILsLM18mmbMJBEp1RcMEzIbUa CkZZuYM9oDw2Q5CB5DLLL9oBL85Fjqw+hkhKbTnyTVrsIeUagQIthQIiN 8M7LuIHaIj9tR2waYXP0NL5S7UQkJzPoT1sVzg8dOrapDOR3+MZmeKK9W g==; X-CSE-ConnectionGUID: eHeMbpSaTUibXp2n1JKz8g== X-CSE-MsgGUID: 9EDM0CHzSFK0ggNVoCmwaw== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="47717512" X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="47717512" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 03:08:46 -0700 X-CSE-ConnectionGUID: afkR8P6STuODLi3Pu+rtaQ== X-CSE-MsgGUID: RZX/sFomSPezzdR+kbt43A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="136965493" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.201]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 03:08:44 -0700 From: Jani Nikula To: Suraj Kandpal , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com, Suraj Kandpal Subject: Re: [PATCH 05/18] drm/i915/dpll: Rename intel_shared_dpll_funcs In-Reply-To: <20250509042729.1152004-6-suraj.kandpal@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250509042729.1152004-1-suraj.kandpal@intel.com> <20250509042729.1152004-6-suraj.kandpal@intel.com> Date: Fri, 09 May 2025 13:08:41 +0300 Message-ID: <87y0v6kseu.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 09 May 2025, Suraj Kandpal wrote: > Rename intel_shared_dpll_funcs to intel_dpll_funcs > since it needs to represent both shared and individual > dplls. > > --v2 > -Change intel_global_dpll to intel_dpll_global to be more > in line with the naming standard where the name should > start with the file name [Jani] > > --v3 > -Drop shared and global altogether [Jani] > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 24 +++++++++---------- > drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 4 ++-- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > index 9974fdb6eaeb..bdad4d72cc01 100644 > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c > @@ -64,7 +64,7 @@ > */ > > /* platform specific hooks for managing DPLLs */ > -struct intel_shared_dpll_funcs { > +struct intel_dpll_funcs { > /* > * Hook for enabling the pll, called from intel_enable_shared_dpll() if > * the pll is not already enabled. > @@ -670,7 +670,7 @@ static bool ibx_compare_hw_state(const struct intel_dpll_hw_state *_a, > a->fp1 == b->fp1; > } > > -static const struct intel_shared_dpll_funcs ibx_pch_dpll_funcs = { > +static const struct intel_dpll_funcs ibx_pch_dpll_funcs = { > .enable = ibx_pch_dpll_enable, > .disable = ibx_pch_dpll_disable, > .get_hw_state = ibx_pch_dpll_get_hw_state, > @@ -1270,14 +1270,14 @@ static bool hsw_compare_hw_state(const struct intel_dpll_hw_state *_a, > a->spll == b->spll; > } > > -static const struct intel_shared_dpll_funcs hsw_ddi_wrpll_funcs = { > +static const struct intel_dpll_funcs hsw_ddi_wrpll_funcs = { > .enable = hsw_ddi_wrpll_enable, > .disable = hsw_ddi_wrpll_disable, > .get_hw_state = hsw_ddi_wrpll_get_hw_state, > .get_freq = hsw_ddi_wrpll_get_freq, > }; > > -static const struct intel_shared_dpll_funcs hsw_ddi_spll_funcs = { > +static const struct intel_dpll_funcs hsw_ddi_spll_funcs = { > .enable = hsw_ddi_spll_enable, > .disable = hsw_ddi_spll_disable, > .get_hw_state = hsw_ddi_spll_get_hw_state, > @@ -1302,7 +1302,7 @@ static bool hsw_ddi_lcpll_get_hw_state(struct intel_display *display, > return true; > } > > -static const struct intel_shared_dpll_funcs hsw_ddi_lcpll_funcs = { > +static const struct intel_dpll_funcs hsw_ddi_lcpll_funcs = { > .enable = hsw_ddi_lcpll_enable, > .disable = hsw_ddi_lcpll_disable, > .get_hw_state = hsw_ddi_lcpll_get_hw_state, > @@ -2004,14 +2004,14 @@ static bool skl_compare_hw_state(const struct intel_dpll_hw_state *_a, > a->cfgcr2 == b->cfgcr2; > } > > -static const struct intel_shared_dpll_funcs skl_ddi_pll_funcs = { > +static const struct intel_dpll_funcs skl_ddi_pll_funcs = { > .enable = skl_ddi_pll_enable, > .disable = skl_ddi_pll_disable, > .get_hw_state = skl_ddi_pll_get_hw_state, > .get_freq = skl_ddi_pll_get_freq, > }; > > -static const struct intel_shared_dpll_funcs skl_ddi_dpll0_funcs = { > +static const struct intel_dpll_funcs skl_ddi_dpll0_funcs = { > .enable = skl_ddi_dpll0_enable, > .disable = skl_ddi_dpll0_disable, > .get_hw_state = skl_ddi_dpll0_get_hw_state, > @@ -2486,7 +2486,7 @@ static bool bxt_compare_hw_state(const struct intel_dpll_hw_state *_a, > a->pcsdw12 == b->pcsdw12; > } > > -static const struct intel_shared_dpll_funcs bxt_ddi_pll_funcs = { > +static const struct intel_dpll_funcs bxt_ddi_pll_funcs = { > .enable = bxt_ddi_pll_enable, > .disable = bxt_ddi_pll_disable, > .get_hw_state = bxt_ddi_pll_get_hw_state, > @@ -4129,21 +4129,21 @@ static bool icl_compare_hw_state(const struct intel_dpll_hw_state *_a, > a->mg_pll_tdc_coldst_bias == b->mg_pll_tdc_coldst_bias; > } > > -static const struct intel_shared_dpll_funcs combo_pll_funcs = { > +static const struct intel_dpll_funcs combo_pll_funcs = { > .enable = combo_pll_enable, > .disable = combo_pll_disable, > .get_hw_state = combo_pll_get_hw_state, > .get_freq = icl_ddi_combo_pll_get_freq, > }; > > -static const struct intel_shared_dpll_funcs tbt_pll_funcs = { > +static const struct intel_dpll_funcs tbt_pll_funcs = { > .enable = tbt_pll_enable, > .disable = tbt_pll_disable, > .get_hw_state = tbt_pll_get_hw_state, > .get_freq = icl_ddi_tbt_pll_get_freq, > }; > > -static const struct intel_shared_dpll_funcs mg_pll_funcs = { > +static const struct intel_dpll_funcs mg_pll_funcs = { > .enable = mg_pll_enable, > .disable = mg_pll_disable, > .get_hw_state = mg_pll_get_hw_state, > @@ -4191,7 +4191,7 @@ static const struct intel_dpll_mgr ehl_pll_mgr = { > .compare_hw_state = icl_compare_hw_state, > }; > > -static const struct intel_shared_dpll_funcs dkl_pll_funcs = { > +static const struct intel_dpll_funcs dkl_pll_funcs = { > .enable = mg_pll_enable, > .disable = mg_pll_disable, > .get_hw_state = dkl_pll_get_hw_state, > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h > index d93072486831..658174b99db3 100644 > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h > @@ -41,7 +41,7 @@ struct intel_crtc; > struct intel_crtc_state; > struct intel_encoder; > struct intel_shared_dpll; > -struct intel_shared_dpll_funcs; > +struct intel_dpll_funcs; Nitpick, these should remain sorted. Reviewed-by: Jani Nikula > > /** > * enum intel_dpll_id - possible DPLL ids > @@ -314,7 +314,7 @@ struct dpll_info { > /** > * @funcs: platform specific hooks > */ > - const struct intel_shared_dpll_funcs *funcs; > + const struct intel_dpll_funcs *funcs; > > /** > * @id: unique identifier for this DPLL -- Jani Nikula, Intel