From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>,
linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Make sb update interval tunable
Date: Sat, 22 Feb 2025 15:02:39 +0530 [thread overview]
Message-ID: <87y0xygw94.fsf@gmail.com> (raw)
In-Reply-To: <86b177b0b0a863362f11afa3fd835c5734e14ef7.1740212945.git.ojaswin@linux.ibm.com>
Ojaswin Mujoo <ojaswin@linux.ibm.com> writes:
> Currently, outside error paths, we auto commit the super block after 1
> hour has passed and 16MB worth of updates have been written since last
> commit. This is a policy decision so make this tunable while keeping the
> defaults same. This is useful if user wants to tweak the superblock
> update behavior or for debugging the codepath by allowing to trigger it
> more frequently.
>
> We can now tweak the super block update using sb_update_sec and
> sb_update_kb files in /sys/fs/ext4/<dev>/
Agree that this could be useful as a tunable knob for various reasons
rather than being a hardcoded value within kernel.
The patch also looks good to me. Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
next prev parent reply other threads:[~2025-02-22 10:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 8:40 [PATCH 0/2] Fix a BUG_ON crashing the kernel in start_this_handle Ojaswin Mujoo
2025-02-22 8:40 ` [PATCH 1/2] ext4: only defer sb update on error if SB_ACTIVE Ojaswin Mujoo
2025-02-24 14:52 ` Jan Kara
2025-02-27 11:20 ` Ojaswin Mujoo
2025-03-04 10:25 ` Jan Kara
2025-03-04 12:54 ` Ojaswin Mujoo
2025-03-05 4:14 ` Ritesh Harjani
2025-02-25 1:53 ` Baokun Li
2025-02-25 12:06 ` Ojaswin Mujoo
2025-02-26 1:55 ` Baokun Li
2025-02-27 11:43 ` Ojaswin Mujoo
2025-02-27 12:51 ` Baokun Li
2025-03-03 17:30 ` Ojaswin Mujoo
2025-02-22 8:40 ` [PATCH 2/2] ext4: Make sb update interval tunable Ojaswin Mujoo
2025-02-22 9:32 ` Ritesh Harjani (IBM) [this message]
2025-02-24 14:27 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0xygw94.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.