From: Fabiano Rosas <farosas@suse.de>
To: Thomas Huth <thuth@redhat.com>,
Nabih Estefan <nabihestefan@google.com>,
peter.maydell@linaro.org
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, lvivier@redhat.com,
pbonzini@redhat.com, roqueh@google.com, venture@google.com,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test
Date: Fri, 13 Dec 2024 15:48:54 -0300 [thread overview]
Message-ID: <87y10jctbd.fsf@suse.de> (raw)
In-Reply-To: <f03adc63-5167-4982-90e6-70b65f0c90cc@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 13/12/2024 01.26, Nabih Estefan wrote:
>> Recent CDMSK Watchdog changes (eff9dc5660fad3a610171c56a5ec3fada245e519)
>> updated the CDMSK APB Watchdog to not free run out of reset. That led to
>> this test failing since it never triggers the watchdog to start running.
>> No watchdog running means that the timer and counter in the test cannot
>> start, leading to failures in the assert statements throughout the test.
>> Adding a reset and enable of the watchdog to the reset function solves
>> this problem by enabling the watchdog and thus letting the timer and
>> counter run as expected
>>
>> Also renaming the reset_counter_and_timer function since it now also
>> affects the watchdog.
>>
>> To reproduce the failure at HEAD:
>> ./configure --target-list=arm-softmmu
>> make -j check-report-qtest-arm.junit.xml
>>
>> Signed-off-by: Nabih Estefan <nabihestefan@google.com>
I don't see any failure with the sse-timer-test on master
(83aaec1d5a). Is it supposed to be intermittent? Nabih, can you confirm
whether this is the same issue Thomas has seen?
> I think this fixes the problem that I was seeing on Travis-CI:
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2702
I did see this^ issue, however, with Philippe's series [1] (and this
patch doesn't fix it).
Here's a CI job with both series applied:
https://gitlab.com/farosas/qemu/-/jobs/8638126011
1- https://lore.kernel.org/r/20241211233727.98923-2-philmd@linaro.org
next prev parent reply other threads:[~2024-12-13 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 0:26 [PATCH] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test Nabih Estefan
2024-12-13 12:26 ` Thomas Huth
2024-12-13 18:48 ` Fabiano Rosas [this message]
2024-12-13 19:20 ` Nabih Estefan
2024-12-13 21:08 ` Fabiano Rosas
2024-12-13 21:09 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y10jctbd.fsf@suse.de \
--to=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=nabihestefan@google.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=roqueh@google.com \
--cc=thuth@redhat.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.