From: Michael Ellerman <mpe@ellerman.id.au>
To: Bart Van Assche <bvanassche@acm.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 04/22] powerpc/cell: Switch to irq_get_nr_irqs()
Date: Wed, 16 Oct 2024 10:36:14 +1100 [thread overview]
Message-ID: <87y12pndld.fsf@mail.lhotse> (raw)
In-Reply-To: <20241015190953.1266194-5-bvanassche@acm.org>
Bart Van Assche <bvanassche@acm.org> writes:
> Use the irq_get_nr_irqs() function instead of the global variable
> 'nr_irqs'. Prepare for changing 'nr_irqs' from an exported global
> variable into a variable with file scope.
>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> arch/powerpc/platforms/cell/axon_msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
> diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c
> index 28dc86744cac..d243f7fd8982 100644
> --- a/arch/powerpc/platforms/cell/axon_msi.c
> +++ b/arch/powerpc/platforms/cell/axon_msi.c
> @@ -112,7 +112,7 @@ static void axon_msi_cascade(struct irq_desc *desc)
> pr_devel("axon_msi: woff %x roff %x msi %x\n",
> write_offset, msic->read_offset, msi);
>
> - if (msi < nr_irqs && irq_get_chip_data(msi) == msic) {
> + if (msi < irq_get_nr_irqs() && irq_get_chip_data(msi) == msic) {
> generic_handle_irq(msi);
> msic->fifo_virt[idx] = cpu_to_le32(0xffffffff);
> } else {
next prev parent reply other threads:[~2024-10-15 23:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 19:09 [PATCH v3 00/22] Reduce the scope of 'nr_irqs' Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 01/22] genirq: Introduce irq_get_nr_irqs() and irq_set_nr_irqs() Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 02/22] ARM: Switch to irq_get_nr_irqs() / irq_set_nr_irqs() Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 03/22] LoongArch: Switch to irq_set_nr_irqs() Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 04/22] powerpc/cell: Switch to irq_get_nr_irqs() Bart Van Assche
2024-10-15 23:36 ` Michael Ellerman [this message]
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 05/22] s390/irq: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 06/22] x86/acpi: Switch to irq_get_nr_irqs() and irq_set_nr_irqs() Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 07/22] hpet: Switch to irq_get_nr_irqs() Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 08/22] net: 3com: 3c59x: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 09/22] net: hamradio: baycom_ser_fdx: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 10/22] net: hamradio: scc: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 11/22] scsi: aha152x: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 12/22] serial: core: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 13/22] serial: 8250: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 14/22] serial: amba-pl010: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 15/22] serial: amba-pl011: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 16/22] serial: cpm_uart: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 17/22] serial: ucc_uart: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 18/22] sh: intc: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 19/22] xen/events: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 20/22] fs/procfs: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 21/22] genirq: " Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
2024-10-15 19:09 ` [PATCH v3 22/22] genirq: Unexport nr_irqs Bart Van Assche
2024-10-16 20:04 ` [tip: irq/core] " tip-bot2 for Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y12pndld.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.