From: Ritesh Harjani <ritesh.list@gmail.com>
To: Seunghwan Baek <sh8267.baek@samsung.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org, quic_asutoshd@quicinc.com,
adrian.hunter@intel.com
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
junwoo80.lee@samsung.com, dh0421.hwang@samsung.com,
jangsub.yi@samsung.com, sh043.lee@samsung.com,
cw9316.lee@samsung.com, sh8267.baek@samsung.com,
wkon.kim@samsung.com, stable@vger.kernel.org
Subject: Re: [PATCH] mmc : fix for check cqe halt.
Date: Wed, 28 Aug 2024 12:11:51 +0530 [thread overview]
Message-ID: <87y14hqhcg.fsf@gmail.com> (raw)
In-Reply-To: <874j75s0rg.fsf@gmail.com>
Ritesh Harjani <ritesh.list@gmail.com> writes:
> Seunghwan Baek <sh8267.baek@samsung.com> writes:
>
>> To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT
>> bit. At this time, we need to check with &, not &&.
>>
>> Fixes: 0653300224a6 ("mmc: cqhci: rename cqhci.c to cqhci-core.c")
Correction. This should be:
Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
Subject can be:
mmc: cqhci: Fix checking of CQHCI_HALT state
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Seunghwan Baek <sh8267.baek@samsung.com>
>> ---
>> drivers/mmc/host/cqhci-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks for fixing it!
> Small suggestion below. But this still looks good to me, so either ways-
>
> Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
With above changes please feel free to add RVB.
-ritesh
next prev parent reply other threads:[~2024-08-28 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240828042653epcas1p1952b6cee9484b53d86727dd0e041a0b5@epcas1p1.samsung.com>
2024-08-28 4:26 ` [PATCH] mmc : fix for check cqe halt Seunghwan Baek
2024-08-28 4:57 ` Ritesh Harjani
2024-08-28 6:41 ` Ritesh Harjani [this message]
[not found] <CGME20240823071040epcas1p1309967537fb6286a9e67a38e598ce104@epcas1p1.samsung.com>
2024-08-23 7:10 ` Seunghwan Baek
2024-08-23 7:22 ` Dragan Simic
2024-08-23 7:23 ` Dragan Simic
2024-08-23 11:00 ` Ulf Hansson
2024-08-26 5:39 ` Seunghwan Baek
2024-08-26 11:35 ` kernel test robot
2024-08-26 11:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y14hqhcg.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=cw9316.lee@samsung.com \
--cc=dh0421.hwang@samsung.com \
--cc=grant.jung@samsung.com \
--cc=jangsub.yi@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_asutoshd@quicinc.com \
--cc=sh043.lee@samsung.com \
--cc=sh8267.baek@samsung.com \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wkon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.