All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Max Ramanouski <max8rr8@gmail.com>,
	x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, linux-kernel@vger.kernel.org,
	jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org
Cc: Max Ramanouski <max8rr8@gmail.com>
Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap()
Date: Mon, 12 Aug 2024 23:13:54 +0200	[thread overview]
Message-ID: <87y151qwa5.ffs@tglx> (raw)
In-Reply-To: <20240812203538.82548-1-max8rr8@gmail.com>

On Mon, Aug 12 2024 at 23:35, Max Ramanouski wrote:
> On systems that use HMM (most notably amdgpu driver) high_memory
> can jump over VMALLOC_START due to pages at the end of physical
> space being added with add_pages(), while gap for new pages left
> by KASLR is as small as 10TB. This results in early exit from
> iounmap() leading to leaking, and additional problems with rebinding
> devices to vfio_pci from other drivers with error of conflicting
> memtypes, as memtypes aren't freed in iounmap().
>
> Replace comparison against high_memory with is_ioremap_addr() to
> fix the issue and make x86 iounmap() implementation more similar
> to generic one, it also uses is_ioremap_addr() to validate pointer.
>
> Fixes: 41e94a851304 ("add devm_memremap_pages")

This fixes absolutely nothing as we discussed already. The underlying
problem is that high_memory can spill over into the VMALLOC area.

Seriously?

Thanks,

        tglx


  reply	other threads:[~2024-08-12 21:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 20:35 [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() Max Ramanouski
2024-08-12 21:13 ` Thomas Gleixner [this message]
2024-08-14  4:28 ` Christoph Hellwig
2024-08-14 10:30   ` Thomas Gleixner
2024-08-14 12:08     ` Alistair Popple
2024-08-14 12:16       ` Christoph Hellwig
2024-08-14 14:11         ` Thomas Gleixner
2024-08-15  5:02           ` Christoph Hellwig
2024-08-15 13:41           ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y151qwa5.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=jhubbard@nvidia.com \
    --cc=jniethe@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=max8rr8@gmail.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.