From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A959C52D7C for ; Fri, 9 Aug 2024 16:39:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6009E8436B; Fri, 9 Aug 2024 16:39:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id wFniAO1FFQs9; Fri, 9 Aug 2024 16:39:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C994F841C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1723221542; bh=MF+yZSiYhfhr7ebTdXx/fOTMkpicTdLJUYY+rC7kXPU=; h=From:To:In-Reply-To:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=saahzJeKPB4/CekLQWUd5qLg/j3hgJUaTxISr6iTHm2V7JYQ9Z8PoM+hJCb3Js6Dd sPTDkLf2XrAWtdOqOnCtw44Xv52poUXCLHI71p5rYqCuyDu0BYURB/bTmCkKHUV0pd ukLajbE5y4zxFxrcfEGCry5VMp9oGOdnEH+ogNW311PIfEim10fqRgtsZrGyZXNbp4 0rEgWMAlD3fbmxUKgg0tP5Qm77AQ/e5VBIi4jWsCTlGQWEp0nRMEJ3hg35I9PAD0AW WKSN05EwzfxfMI5qCtdflKF0JOF/RPuUMu/ZZxFqOhyh34dxDF4BQ/I3uS8oUQXvon YQ/GQRwSM/nyg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id C994F841C7; Fri, 9 Aug 2024 16:39:02 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 8ED581BF867 for ; Fri, 9 Aug 2024 16:39:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 87C4041123 for ; Fri, 9 Aug 2024 16:39:01 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yaJZn2NDEa44 for ; Fri, 9 Aug 2024 16:39:00 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.13; helo=mgamail.intel.com; envelope-from=vinicius.gomes@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 6066F403D6 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6066F403D6 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6066F403D6 for ; Fri, 9 Aug 2024 16:39:00 +0000 (UTC) X-CSE-ConnectionGUID: 6LGIztEcR1K/3pF+eS0WpA== X-CSE-MsgGUID: t4kMRbIIRc2eG88CconbeA== X-IronPort-AV: E=McAfee;i="6700,10204,11159"; a="24305302" X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="24305302" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 09:39:00 -0700 X-CSE-ConnectionGUID: tLOrSCFdRauODjLbCnpZfg== X-CSE-MsgGUID: wuAx09PISS6NT9TXeaW3qg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="57696321" Received: from bjrankin-mobl3.amr.corp.intel.com (HELO vcostago-mobl3) ([10.124.221.140]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 09:38:59 -0700 From: Vinicius Costa Gomes To: Daiwei Li In-Reply-To: References: Date: Fri, 09 Aug 2024 09:38:58 -0700 Message-ID: <87y155wt0d.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723221540; x=1754757540; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=DYzuCPdoyOkh7yU5ZV53ubQ5DiZzTv7NNppITDFVMSQ=; b=Uq5P3OxaPTUQOHVTpH27MsAOUwF8E72Rya26VOsWBH3fWlhPzpqFzB+c tLqTock8a0RAYTeJxKoha/0AIsiO5/49aB8NzsCtRJ4CQ4MJ+GooM8CIn dOR29CWjdW5PRDj1su0UMbX8pH2eS7gGVK4XKZyIZ/20w2YnGLltLJIiz su+Pd7J14l/OY7PQMXOOfgtyHaBoVirExa6tCs54aNrXSGWGRzVSuzxlS NbIx++UxsgejTxXOZk1pkNFLuJBQNHKKvM9G2AlP6wQlUWZ+VW1tWCfap NrN1pw4aub0FsRY2idTmUkhyCAm5xznLxz0RysGi7LVRM3/v1iZPsGZcU Q==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Uq5P3Oxa Subject: Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sasha.neftin@intel.com, netdev@vger.kernel.org, richardcochran@gmail.com, kurt@linutronix.de, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, edumazet@google.com, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, kuba@kernel.org, anthony.l.nguyen@intel.com, pabeni@redhat.com, davem@davemloft.net Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Daiwei Li writes: > Hi, > > It appears this change breaks PTP on the 82580 controller, as ptp4l reports: > >> timed out while polling for tx timestamp increasing tx_timestamp_timeout or >> increasing kworker priority may correct this issue, but a driver bug likely >> causes it > > The 82580 controller has a hardware bug in which reading TSICR doesn't clear > it. See this thread > https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@intel.com/ where the > bug was confirmed by an Intel employee. Any chance we could add back the ack > for 82580 specifically? Thanks! Of course, I'll prepare a patch for that. Thanks for digging that one up. Cheers, -- Vinicius From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A41C1CA94; Fri, 9 Aug 2024 16:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723221545; cv=none; b=R0kr3GPHuk2orYg7+OTwVDlqkG2ohHROSnpb6lEBryRYSsVRREBSKnwQTgK6CwZWKlZzoytRx82aLluTvWwsAWxQ2r66iy1dzTYRcaPzuETWROcJzmtjlLxYP1u86h2FZniKpmH86/zueTsNDSqWNE0A5mvlzT2ZnzQ7z9t6sI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723221545; c=relaxed/simple; bh=DYzuCPdoyOkh7yU5ZV53ubQ5DiZzTv7NNppITDFVMSQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=PHFThJRYJx3nyokM1K2FZTxiHZvrRl6h0EZSwftzLpF2+bBSOKf8eTkP5eTsLRxsrCaurL7UJknVh9TmCfdQd0wuNcpXb4TFPBocl0+J4QrkOLvxDTCa21K+G1YYo/NeYpSZGxT9WXXE8kyT0RF3Hq/GSrDQcK3k3HeErJJn3Ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Uq5P3Oxa; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Uq5P3Oxa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723221540; x=1754757540; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=DYzuCPdoyOkh7yU5ZV53ubQ5DiZzTv7NNppITDFVMSQ=; b=Uq5P3OxaPTUQOHVTpH27MsAOUwF8E72Rya26VOsWBH3fWlhPzpqFzB+c tLqTock8a0RAYTeJxKoha/0AIsiO5/49aB8NzsCtRJ4CQ4MJ+GooM8CIn dOR29CWjdW5PRDj1su0UMbX8pH2eS7gGVK4XKZyIZ/20w2YnGLltLJIiz su+Pd7J14l/OY7PQMXOOfgtyHaBoVirExa6tCs54aNrXSGWGRzVSuzxlS NbIx++UxsgejTxXOZk1pkNFLuJBQNHKKvM9G2AlP6wQlUWZ+VW1tWCfap NrN1pw4aub0FsRY2idTmUkhyCAm5xznLxz0RysGi7LVRM3/v1iZPsGZcU Q==; X-CSE-ConnectionGUID: jxvaxB2AR2ClQ8yr4i2UwA== X-CSE-MsgGUID: vm1U2BpNR1OaVgCb4IlBOw== X-IronPort-AV: E=McAfee;i="6700,10204,11159"; a="24305303" X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="24305303" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 09:39:00 -0700 X-CSE-ConnectionGUID: tLOrSCFdRauODjLbCnpZfg== X-CSE-MsgGUID: wuAx09PISS6NT9TXeaW3qg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,276,1716274800"; d="scan'208";a="57696321" Received: from bjrankin-mobl3.amr.corp.intel.com (HELO vcostago-mobl3) ([10.124.221.140]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2024 09:38:59 -0700 From: Vinicius Costa Gomes To: Daiwei Li Cc: anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, kuba@kernel.org, kurt@linutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, richardcochran@gmail.com, sasha.neftin@intel.com Subject: Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events In-Reply-To: References: Date: Fri, 09 Aug 2024 09:38:58 -0700 Message-ID: <87y155wt0d.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Daiwei Li writes: > Hi, > > It appears this change breaks PTP on the 82580 controller, as ptp4l reports: > >> timed out while polling for tx timestamp increasing tx_timestamp_timeout or >> increasing kworker priority may correct this issue, but a driver bug likely >> causes it > > The 82580 controller has a hardware bug in which reading TSICR doesn't clear > it. See this thread > https://lore.kernel.org/all/CDCB8BE0.1EC2C%25matthew.vick@intel.com/ where the > bug was confirmed by an Intel employee. Any chance we could add back the ack > for 82580 specifically? Thanks! Of course, I'll prepare a patch for that. Thanks for digging that one up. Cheers, -- Vinicius