Re: [PATCH 04/13] irqchip/armada-370-xp: Add the __init attribute to mpic_msi_init()

[Thomas Gleixner <tglx@linutronix.de>]

On Mon, Jul 15 2024 at 12:51, Marek Behún wrote:

> Add the __init attribute to the mpic_msi_init() function. It is only
> called from the device initializer, and so can be dropped after boot is
> complete.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
>  drivers/irqchip/irq-armada-370-xp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
> index 1739bf768696..2185f79007f4 100644
> --- a/drivers/irqchip/irq-armada-370-xp.c
> +++ b/drivers/irqchip/irq-armada-370-xp.c
> @@ -318,8 +318,8 @@ static void mpic_msi_reenable_percpu(void)
>  	writel(1, per_cpu_int_base + MPIC_INT_CLEAR_MASK);
>  }
>  
> -static int mpic_msi_init(struct device_node *node,
> -			 phys_addr_t main_int_phys_base)
> +static int __init mpic_msi_init(struct device_node *node,
> +				phys_addr_t main_int_phys_base)

Please get rid of the line break while at it.

Thanks,

        tglx