From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, pierrick.bouvier@linaro.org
Subject: Re: [PATCH 3/7] accel/tcg: Return the TranslationBlock from cpu_unwind_state_data
Date: Fri, 31 May 2024 17:52:05 +0100 [thread overview]
Message-ID: <87y17papqi.fsf@draig.linaro.org> (raw)
In-Reply-To: <20240416040609.1313605-4-richard.henderson@linaro.org> (Richard Henderson's message of "Mon, 15 Apr 2024 21:06:05 -0700")
Richard Henderson <richard.henderson@linaro.org> writes:
> Fix the i386 get_memio_eip function to use tb->cflags
> instead of cs->tcg_cflags.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/exec/cpu-common.h | 9 +++++----
> accel/tcg/translate-all.c | 9 +++++----
> target/i386/helper.c | 6 ++++--
> 3 files changed, 14 insertions(+), 10 deletions(-)
>
<snip>
>
> /* Per x86_restore_state_to_opc. */
> - if (cs->tcg_cflags & CF_PCREL) {
> + if (tb->cflags & CF_PCREL) {
> return (env->eip & TARGET_PAGE_MASK) | data[0];
this has a merge conflict with subsequent changes.
> } else {
> return data[0] - env->segs[R_CS].base;
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-05-31 16:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 4:06 [PATCH 0/7] plugins: Use unwind info for special gdb registers Richard Henderson
2024-04-16 4:06 ` [PATCH 1/7] tcg: Introduce INDEX_op_plugin_pc Richard Henderson
2024-04-18 17:53 ` Pierrick Bouvier
2024-04-16 4:06 ` [PATCH 2/7] accel/tcg: Set CPUState.plugin_ra before all plugin callbacks Richard Henderson
2024-04-18 17:54 ` Pierrick Bouvier
2024-05-31 16:46 ` Alex Bennée
2024-04-16 4:06 ` [PATCH 3/7] accel/tcg: Return the TranslationBlock from cpu_unwind_state_data Richard Henderson
2024-04-18 17:54 ` Pierrick Bouvier
2024-05-31 16:52 ` Alex Bennée [this message]
2024-04-16 4:06 ` [PATCH 4/7] plugins: Introduce TCGCPUOps callbacks for mid-tb register reads Richard Henderson
2024-04-18 17:55 ` Pierrick Bouvier
2024-04-16 4:06 ` [PATCH 5/7] target/i386: Split out gdb-internal.h Richard Henderson
2024-04-18 17:55 ` Pierrick Bouvier
2024-05-31 17:00 ` Alex Bennée
2024-04-16 4:06 ` [PATCH 6/7] target/i386: Introduce cpu_compute_eflags_ccop Richard Henderson
2024-04-18 17:56 ` Pierrick Bouvier
2024-04-16 4:06 ` [PATCH 7/7] target/i386: Implement TCGCPUOps for plugin register reads Richard Henderson
2024-04-18 17:56 ` Pierrick Bouvier
2024-04-17 0:35 ` [PATCH 0/7] plugins: Use unwind info for special gdb registers Pierrick Bouvier
2024-04-17 2:40 ` Richard Henderson
2024-04-17 15:39 ` Pierrick Bouvier
2024-04-22 16:49 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y17papqi.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.